From 4201e96cbc80525b2a42295b1ab43967f844160f Mon Sep 17 00:00:00 2001 From: Steven Luong Date: Tue, 25 Jun 2019 22:36:26 -0700 Subject: vmxnet3: custom dump and debug cli fix Add missing custom dump for vmxnet3_create, vmxnet3_delete, and vmxnet3_dump. Fix vmxnet3_create debug cli which may not parse all parameters correctly due to passing address of u16 to unformat(). The fix is to use a u32 local variable to receive the correct value from unformat(). Type: fix Change-Id: I04251c9ed0ab397ed4b1b5843a73880aec98b9f6 Signed-off-by: Steven Luong --- src/plugins/vmxnet3/cli.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'src/plugins/vmxnet3/cli.c') diff --git a/src/plugins/vmxnet3/cli.c b/src/plugins/vmxnet3/cli.c index 776901e8ac2..76db1cab7ed 100644 --- a/src/plugins/vmxnet3/cli.c +++ b/src/plugins/vmxnet3/cli.c @@ -32,6 +32,7 @@ vmxnet3_create_command_fn (vlib_main_t * vm, unformat_input_t * input, { unformat_input_t _line_input, *line_input = &_line_input; vmxnet3_create_if_args_t args; + u32 size; /* Get a line of input. */ if (!unformat_user (input, unformat_line_input, line_input)) @@ -46,14 +47,14 @@ vmxnet3_create_command_fn (vlib_main_t * vm, unformat_input_t * input, args.enable_elog = 1; else if (unformat (line_input, "bind")) args.bind = 1; - else if (unformat (line_input, "rx-queue-size %u", &args.rxq_size)) - ; - else if (unformat (line_input, "tx-queue-size %u", &args.txq_size)) - ; - else if (unformat (line_input, "num-tx-queues %u", &args.txq_num)) - ; - else if (unformat (line_input, "num-rx-queues %u", &args.rxq_num)) - ; + else if (unformat (line_input, "rx-queue-size %u", &size)) + args.rxq_size = size; + else if (unformat (line_input, "tx-queue-size %u", &size)) + args.txq_size = size; + else if (unformat (line_input, "num-tx-queues %u", &size)) + args.txq_num = size; + else if (unformat (line_input, "num-rx-queues %u", &size)) + args.rxq_num = size; else return clib_error_return (0, "unknown input `%U'", format_unformat_error, input); -- cgit 1.2.3-korg