From 269549491ae6c8d9c35d6b4fa9441ad15e6b82f0 Mon Sep 17 00:00:00 2001 From: Matthew Smith Date: Thu, 20 Feb 2020 08:58:15 -0600 Subject: vrrp: fix coverity errors Type: fix Fixes: 39e9428b90 Fix warnings about potential problems with an implicit type cast and a null pointer dereference. Change-Id: I8c8d220e79ba45b62ba783cfe53cb49eef175fc8 Signed-off-by: Matthew Smith --- src/plugins/vrrp/vrrp_packet.c | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'src/plugins/vrrp/vrrp_packet.c') diff --git a/src/plugins/vrrp/vrrp_packet.c b/src/plugins/vrrp/vrrp_packet.c index f624b1876c3..6b0d4c96c2d 100644 --- a/src/plugins/vrrp/vrrp_packet.c +++ b/src/plugins/vrrp/vrrp_packet.c @@ -282,6 +282,16 @@ vrrp_adv_send (vrrp_vr_t * vr, int shutdown) if (is_unicast) n_buffers = vec_len (vr->config.peer_addrs); + if (n_buffers < 1) + { + /* A unicast VR will not start without peers added so this should + * not happen. Just avoiding a crash if it happened somehow. + */ + clib_warning ("Unicast VR configuration corrupted for %U", + format_vrrp_vr_key, vr); + return -1; + } + vec_validate (bi, n_buffers - 1); if (vlib_buffer_alloc (vm, bi, n_buffers) != n_buffers) { -- cgit 1.2.3-korg