From 1bd6f61820c6c15534ebb04a4b070ba84bf08a9d Mon Sep 17 00:00:00 2001 From: Benoît Ganne Date: Thu, 16 Jul 2020 12:03:35 +0200 Subject: vppinfra: fix format_c_identifier vector overflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In case of vector, we must check length before trying to access element. Also fix wrong DPDK plugin workaround. Type: fix Change-Id: I2ecef1c88ebef2362f48cab0d462699aa43cd4b9 Signed-off-by: Benoît Ganne --- src/plugins/dpdk/device/format.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/plugins') diff --git a/src/plugins/dpdk/device/format.c b/src/plugins/dpdk/device/format.c index dad15052b45..19476cb19dd 100644 --- a/src/plugins/dpdk/device/format.c +++ b/src/plugins/dpdk/device/format.c @@ -710,12 +710,10 @@ format_dpdk_device (u8 * s, va_list * args) xstat = vec_elt_at_index(xd->xstats, i); if (verbose == 2 || (verbose && xstat->value)) { - /* format_c_identifier doesn't like c strings inside vector */ - u8 * name = format(0,"%s", xstat_names[i].name); xs = format(xs, "\n%U%-38U%16Lu", format_white_space, indent + 4, - format_c_identifier, name, xstat->value); - vec_free(name); + format_c_identifier, xstat_names[i].name, + xstat->value); } } /* *INDENT-ON* */ -- cgit 1.2.3-korg