From ac60efd523dbbda3952bf4052a5fbeda7cac0a60 Mon Sep 17 00:00:00 2001 From: Florin Coras Date: Wed, 13 Mar 2024 22:03:33 -0700 Subject: tls: handle attepts to renegotiate hs Type: fix Signed-off-by: Florin Coras Change-Id: I549d0c8715e5c06bfc22be26ca1dc78ec3c29a61 --- src/plugins/tlsopenssl/tls_openssl.c | 14 +++++++++++++- src/plugins/tlspicotls/tls_picotls.c | 1 + 2 files changed, 14 insertions(+), 1 deletion(-) (limited to 'src/plugins') diff --git a/src/plugins/tlsopenssl/tls_openssl.c b/src/plugins/tlsopenssl/tls_openssl.c index 87674337807..75e58f6579a 100644 --- a/src/plugins/tlsopenssl/tls_openssl.c +++ b/src/plugins/tlsopenssl/tls_openssl.c @@ -265,6 +265,14 @@ openssl_handle_handshake_failure (tls_ctx_t * ctx) { session_t *app_session; + /* Failed to renegotiate handshake */ + if (ctx->flags & TLS_CONN_F_HS_DONE) + { + tls_notify_app_io_error (ctx); + tls_disconnect_transport (ctx); + return; + } + if (SSL_is_server (((openssl_ctx_t *) ctx)->ssl)) { /* @@ -334,6 +342,10 @@ openssl_ctx_handshake_rx (tls_ctx_t * ctx, session_t * tls_session) if (SSL_in_init (oc->ssl)) return -1; + /* Renegotiated handshake, app must not be notified */ + if (PREDICT_FALSE (ctx->flags & TLS_CONN_F_HS_DONE)) + return 0; + /* * Handshake complete */ @@ -379,7 +391,7 @@ openssl_ctx_handshake_rx (tls_ctx_t * ctx, session_t * tls_session) return -1; } } - + ctx->flags |= TLS_CONN_F_HS_DONE; TLS_DBG (1, "Handshake for %u complete. TLS cipher is %s", oc->openssl_ctx_index, SSL_get_cipher (oc->ssl)); return rv; diff --git a/src/plugins/tlspicotls/tls_picotls.c b/src/plugins/tlspicotls/tls_picotls.c index 88b99a48aa1..81c4b2ecf57 100644 --- a/src/plugins/tlspicotls/tls_picotls.c +++ b/src/plugins/tlspicotls/tls_picotls.c @@ -453,6 +453,7 @@ picotls_ctx_read (tls_ctx_t *ctx, session_t *tcp_session) } } + ctx->flags |= TLS_CONN_F_HS_DONE; if (!svm_fifo_max_dequeue (tcp_session->rx_fifo)) return 0; } -- cgit 1.2.3-korg