From 48bdbcd8f9d573138c43f994ddfff946d8a9d9b5 Mon Sep 17 00:00:00 2001 From: Paul Vinciguerra Date: Wed, 4 Dec 2019 19:43:53 -0500 Subject: tests: fix worker thread initialization from threading.thread __init__: This constructor should always be called with keyword arguments. If a subclass overrides the constructor, it must make sure to invoke the base class constructor (Thread.__init__()) before doing anything else to the thread. Type: test Change-Id: Ifa89202e97053a4baf19e9a0ca0913430d5087a3 Signed-off-by: Paul Vinciguerra --- src/vcl/test/test_vcl.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'src/vcl/test') diff --git a/src/vcl/test/test_vcl.py b/src/vcl/test/test_vcl.py index 804e7457555..d7a44ed7d1e 100644 --- a/src/vcl/test/test_vcl.py +++ b/src/vcl/test/test_vcl.py @@ -26,7 +26,11 @@ _have_iperf3 = have_app(iperf3) class VCLAppWorker(Worker): """ VCL Test Application Worker """ - def __init__(self, build_dir, appname, args, logger, env={}): + def __init__(self, build_dir, appname, executable_args, logger, env=None, + *args, **kwargs): + + if env is None: + env = {} vcl_lib_dir = "%s/vpp/lib" % build_dir if "iperf" in appname: app = appname @@ -38,8 +42,9 @@ class VCLAppWorker(Worker): "%s/libvcl_ldpreload.so" % vcl_lib_dir}) else: app = "%s/vpp/bin/%s" % (build_dir, appname) - self.args = [app] + args - super(VCLAppWorker, self).__init__(self.args, logger, env) + self.args = [app] + executable_args + super(VCLAppWorker, self).__init__(self.args, logger, env, + *args, **kwargs) class VCLTestCase(VppTestCase): -- cgit 1.2.3-korg