From 9c5161aedff8e271cc036faeab58b665a3c8105e Mon Sep 17 00:00:00 2001 From: Dave Wallace Date: Thu, 14 Dec 2017 21:36:31 -0500 Subject: VCL-LDPRELOAD: Fix Coverity Warning CID 178776 - Fix broken unit test code. - Check for NULL ptr in vppcom_session_attr() VPPCOM_ATTR_GET_*_ADDR endpoint parameters. Change-Id: I01169edce098ee855a9cba08893c2b08c93ea6c3 Signed-off-by: Dave Wallace --- src/vcl/vppcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/vcl/vppcom.c') diff --git a/src/vcl/vppcom.c b/src/vcl/vppcom.c index ce222a77234..2e3af1b3526 100644 --- a/src/vcl/vppcom.c +++ b/src/vcl/vppcom.c @@ -3797,7 +3797,7 @@ vppcom_session_attr (uint32_t session_index, uint32_t op, break; case VPPCOM_ATTR_GET_PEER_ADDR: - if (buffer && buflen && (*buflen >= sizeof (*ep))) + if (buffer && buflen && (*buflen >= sizeof (*ep)) && ep->ip) { ep->vrf = session->vrf; ep->is_ip4 = session->peer_addr.is_ip4; @@ -3821,7 +3821,7 @@ vppcom_session_attr (uint32_t session_index, uint32_t op, break; case VPPCOM_ATTR_GET_LCL_ADDR: - if (buffer && buflen && (*buflen >= sizeof (*ep))) + if (buffer && buflen && (*buflen >= sizeof (*ep)) && ep->ip) { ep->vrf = session->vrf; ep->is_ip4 = session->lcl_addr.is_ip4; -- cgit 1.2.3-korg