From 3d57cfdfb529c61fa5ec6e8a04db4ef042e7eb45 Mon Sep 17 00:00:00 2001
From: Dave Barach <dave@barachs.net>
Date: Sat, 4 Apr 2020 18:34:41 -0400
Subject: misc: strcpy be gone

Causes static analysis "vulnerability" warnings

Type: fix
Ticket: VPP-1837

Signed-off-by: Dave Barach <dave@barachs.net>
Change-Id: I272fa69251d70f62178e6dff0423c16f99937af1
(cherry picked from commit 0250090fc0c24214cb1fa969f6e2f585099ee36b)
---
 src/vcl/ldp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/vcl')

diff --git a/src/vcl/ldp.c b/src/vcl/ldp.c
index 3944239ec1a..af9742063fa 100644
--- a/src/vcl/ldp.c
+++ b/src/vcl/ldp.c
@@ -1813,8 +1813,8 @@ getsockopt (int fd, int level, int optname,
 		rv = -EFAULT;
 	      break;
 	    case TCP_CONGESTION:
-	      strcpy (optval, "cubic");
 	      *optlen = strlen ("cubic");
+	      strncpy (optval, "cubic", *optlen + 1);
 	      rv = 0;
 	      break;
 	    default:
-- 
cgit 1.2.3-korg