From 299571aca34d36e637e43cfbba6275662d0d7795 Mon Sep 17 00:00:00 2001 From: Damjan Marion Date: Sat, 19 Mar 2022 00:07:52 +0100 Subject: vppinfra: vector allocator rework - support of in-place growth of vectors (if there is available space next to existing alloc) - drops the need for alloc_aligned_at_offset from memory allocator, which allows easier swap to different memory allocator and reduces malloc overhead - rework of pool and vec macros to inline functions to improve debuggability - fix alignment - in many cases macros were not using native alignment of the particular datatype. Explicitly setting alignment with XXX_aligned() versions of the macro is not needed anymore in > 99% of cases - fix ASAN usage - avoid use of vector of voids, this was root cause of several bugs found in vec_* and pool_* function where sizeof() was used on voids instead of real vector data type - introduce minimal alignment which is currently 8 bytes, vectors will be always aligned at least to that value (underlay allocator actually always provide 16-byte aligned allocs) Type: improvement Change-Id: I20f4b081bb13bbf7bc0ace85cc4e301787f12fdf Signed-off-by: Damjan Marion --- src/vlib/node.h | 2 +- src/vlib/node_funcs.h | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) (limited to 'src/vlib') diff --git a/src/vlib/node.h b/src/vlib/node.h index db8d4246f03..149232638ba 100644 --- a/src/vlib/node.h +++ b/src/vlib/node.h @@ -274,7 +274,7 @@ typedef struct vlib_node_t u32 runtime_index; /* Runtime data for this node. */ - void *runtime_data; + u8 *runtime_data; /* Node flags. */ u16 flags; diff --git a/src/vlib/node_funcs.h b/src/vlib/node_funcs.h index 61a085730fd..de6fd4818be 100644 --- a/src/vlib/node_funcs.h +++ b/src/vlib/node_funcs.h @@ -856,11 +856,9 @@ vlib_process_signal_event_helper (vlib_node_main_t * nm, l = vec_len (data_vec); - data_vec = _vec_resize (data_vec, - /* length_increment */ n_data_elts, - /* total size after increment */ - (l + n_data_elts) * n_data_elt_bytes, - /* header_bytes */ 0, /* data_align */ 0); + data_vec = + _vec_realloc (data_vec, l + n_data_elts, n_data_elt_bytes, + /* header_bytes */ 0, /* data_align */ 0, /* heap */ 0); p->pending_event_data_by_type_index[t] = data_vec; data_to_be_written_by_caller = data_vec + l * n_data_elt_bytes; -- cgit 1.2.3-korg