From a4ba8da26f053db714d77943c01090e968724273 Mon Sep 17 00:00:00 2001 From: Klement Sekera Date: Mon, 18 Oct 2021 12:28:48 +0200 Subject: api: remove legacy pd msg handlers While looking at a coverity warning it was discovered that it's caused by return value modified by pd msg handlers. As these are legacy, it's a good time to remove them and also fix the warning this way. Type: fix Signed-off-by: Klement Sekera Change-Id: Ic72ab8b2b7a2e55188d1c31cfd18a74b7cf82c43 --- src/vlibapi/api_helper_macros.h | 9 --------- 1 file changed, 9 deletions(-) (limited to 'src/vlibapi/api_helper_macros.h') diff --git a/src/vlibapi/api_helper_macros.h b/src/vlibapi/api_helper_macros.h index 2e0a62229f3..7a04bb056f2 100644 --- a/src/vlibapi/api_helper_macros.h +++ b/src/vlibapi/api_helper_macros.h @@ -30,7 +30,6 @@ #define REPLY_MACRO(t) \ do { \ vl_api_registration_t *rp; \ - rv = vl_msg_api_pd_handler (mp, rv); \ rp = vl_api_client_index_to_registration (mp->client_index); \ if (rp == 0) \ return; \ @@ -46,7 +45,6 @@ do { \ #define REPLY_MACRO_END(t) \ do { \ vl_api_registration_t *rp; \ - rv = vl_msg_api_pd_handler (mp, rv); \ rp = vl_api_client_index_to_registration (mp->client_index); \ if (rp == 0) \ return; \ @@ -65,7 +63,6 @@ do { \ #define REPLY_MACRO2(t, body) \ do { \ vl_api_registration_t *rp; \ - rv = vl_msg_api_pd_handler (mp, rv); \ rp = vl_api_client_index_to_registration (mp->client_index); \ if (rp == 0) \ return; \ @@ -81,7 +78,6 @@ do { \ #define REPLY_MACRO2_END(t, body) \ do { \ vl_api_registration_t *rp; \ - rv = vl_msg_api_pd_handler (mp, rv); \ rp = vl_api_client_index_to_registration (mp->client_index); \ if (rp == 0) \ return; \ @@ -101,7 +97,6 @@ do { \ #define REPLY_MACRO2_ZERO(t, body) \ do { \ vl_api_registration_t *rp; \ - rv = vl_msg_api_pd_handler (mp, rv); \ rp = vl_api_client_index_to_registration (mp->client_index); \ if (rp == 0) \ return; \ @@ -117,7 +112,6 @@ do { \ #define REPLY_MACRO_DETAILS2(t, body) \ do { \ vl_api_registration_t *rp; \ - rv = vl_msg_api_pd_handler (mp, rv); \ rp = vl_api_client_index_to_registration (mp->client_index); \ if (rp == 0) \ return; \ @@ -141,7 +135,6 @@ do { \ #define REPLY_MACRO3(t, n, body) \ do { \ vl_api_registration_t *rp; \ - rv = vl_msg_api_pd_handler (mp, rv); \ rp = vl_api_client_index_to_registration (mp->client_index); \ if (rp == 0) \ return; \ @@ -157,7 +150,6 @@ do { \ #define REPLY_MACRO3_ZERO(t, n, body) \ do { \ vl_api_registration_t *rp; \ - rv = vl_msg_api_pd_handler (mp, rv); \ rp = vl_api_client_index_to_registration (mp->client_index); \ if (rp == 0) \ return; \ @@ -174,7 +166,6 @@ do { \ do { \ vl_api_registration_t *rp; \ u8 is_error = 0; \ - rv = vl_msg_api_pd_handler (mp, rv); \ \ rp = vl_api_client_index_to_registration (mp->client_index); \ if (rp == 0) \ -- cgit 1.2.3-korg