From 59ffe5ea1cf585fa9ace7e527083aee4abe7aab7 Mon Sep 17 00:00:00 2001 From: Benoît Ganne Date: Thu, 18 Jul 2019 17:34:28 +0200 Subject: fib: do not dump no-longer valid adjacencies MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In some cases, we can refer to no-longer adjacencies (eg. in traces). Do not dump them in this case as they are probably incorrect (memory can be reused). Type: fix Change-Id: Ib653ba066bb6595ec6ec37d313a3124bce0eeed3 Signed-off-by: Benoît Ganne (cherry picked from commit 138c37af5291e2045075052a4db036be03be4a85) --- src/vnet/adj/adj_mcast.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'src/vnet/adj/adj_mcast.c') diff --git a/src/vnet/adj/adj_mcast.c b/src/vnet/adj/adj_mcast.c index 4454afec630..c94d28e8713 100644 --- a/src/vnet/adj/adj_mcast.c +++ b/src/vnet/adj/adj_mcast.c @@ -329,7 +329,12 @@ format_adj_mcast (u8* s, va_list *ap) { index_t index = va_arg(*ap, index_t); CLIB_UNUSED(u32 indent) = va_arg(*ap, u32); - ip_adjacency_t * adj = adj_get(index); + ip_adjacency_t * adj; + + if (!adj_is_valid(index)) + return format(s, ""); + + adj = adj_get(index); s = format(s, "%U-mcast: ", format_fib_protocol, adj->ia_nh_proto); -- cgit 1.2.3-korg