From f970a75542e6dca13b9810a42c881cbe5b6c9445 Mon Sep 17 00:00:00 2001 From: Fan Zhang Date: Fri, 1 May 2020 13:06:57 +0100 Subject: crypto: fix coverity issues Fix coverity issues in crypto framework and cryptodev engine. Type: fix Signed-off-by: Fan Zhang Change-Id: Ib261da0163c8182c803600db22c5a6dad5a19999 --- src/vnet/crypto/format.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) (limited to 'src/vnet/crypto') diff --git a/src/vnet/crypto/format.c b/src/vnet/crypto/format.c index b58ab7fceb2..c503ac81663 100644 --- a/src/vnet/crypto/format.c +++ b/src/vnet/crypto/format.c @@ -135,30 +135,11 @@ u8 * format_vnet_crypto_async_op (u8 * s, va_list * args) { vnet_crypto_main_t *cm = &crypto_main; - vnet_crypto_async_op_id_t op = va_arg (*args, int); // vnet_crypto_op_id_t); + vnet_crypto_async_op_id_t op = va_arg (*args, vnet_crypto_async_op_id_t); vnet_crypto_async_op_data_t *otd = cm->async_opt_data + op; return format (s, "%U-%U", format_vnet_crypto_async_op_type, otd->type, format_vnet_crypto_async_alg, otd->alg); - - vnet_crypto_async_op_id_t opt = va_arg (*args, vnet_crypto_async_op_id_t); - char *strings[] = { -#define _(n, s, k, t, a) \ - [VNET_CRYPTO_OP_##n##_TAG##t##_AAD##a##_ENC] = s "-enc", \ - [VNET_CRYPTO_OP_##n##_TAG##t##_AAD##a##_DEC] = s "-dec", - foreach_crypto_aead_async_alg -#undef _ -#define _(c, h, s, k ,d) \ - [VNET_CRYPTO_OP_##c##_##h##_TAG##d##_ENC] = s "-enc", \ - [VNET_CRYPTO_OP_##c##_##h##_TAG##d##_DEC] = s "-dec", - foreach_crypto_link_async_alg -#undef _ - }; - - if (opt >= VNET_CRYPTO_ASYNC_OP_N_IDS) - return format (s, "unknown"); - - return format (s, "%s", strings[opt]); } /* -- cgit 1.2.3-korg