From e347acbc31111504c015531e8ad764a86d489309 Mon Sep 17 00:00:00 2001 From: Mohsin Kazmi Date: Mon, 28 Sep 2020 10:26:33 +0000 Subject: virtio: add packet buffering on tx Type: feature This patch adds packet buffering on tx for slow backend which have some jitter/delays in freeing the vrings. There are some limitations to the current design: 1) It only works in poll mode. 2) Atleast 1 rx queue of an interface (with buffering enabled) should be placed on each worker and main thread. Signed-off-by: Mohsin Kazmi Change-Id: Ib93c350298b228e80426e58ac77f3bbc93b8be27 --- src/vnet/devices/virtio/node.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'src/vnet/devices/virtio/node.c') diff --git a/src/vnet/devices/virtio/node.c b/src/vnet/devices/virtio/node.c index 1c9cfd0cc03..42b2590b342 100644 --- a/src/vnet/devices/virtio/node.c +++ b/src/vnet/devices/virtio/node.c @@ -279,11 +279,14 @@ virtio_device_input_gso_inline (vlib_main_t * vm, vlib_node_runtime_t * node, u16 last = vring->last_used_idx; u16 n_left = vring->used->idx - last; - if (vif->packet_coalesce - && clib_spinlock_trylock_if_init (&txq_vring->lockp)) + if (clib_spinlock_trylock_if_init (&txq_vring->lockp)) { - vnet_gro_flow_table_schedule_node_on_dispatcher (vm, - txq_vring->flow_table); + if (vif->packet_coalesce) + vnet_gro_flow_table_schedule_node_on_dispatcher (vm, + txq_vring->flow_table); + else if (vif->packet_buffering) + virtio_vring_buffering_schedule_node_on_dispatcher (vm, + txq_vring->buffering); clib_spinlock_unlock_if_init (&txq_vring->lockp); } -- cgit 1.2.3-korg