From 5cdde5c25a0e71d923a6d56e5c94e058887f95d8 Mon Sep 17 00:00:00 2001 From: jaszha03 Date: Thu, 11 Jul 2019 20:47:24 +0000 Subject: vppinfra: refactor test_and_set spinlocks to use clib_spinlock_t Spinlock performance improved when implemented with compare_and_exchange instead of test_and_set. All instances of test_and_set locks were refactored to use clib_spinlock_t when possible. Some locks e.g. ssvm synchronize between processes rather than threads, so they cannot directly use clib_spinlock_t. Type: refactor Change-Id: Ia16b5d4cd49209b2b57b8df6c94615c28b11bb60 Signed-off-by: Jason Zhang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Lijian Zhang --- src/vnet/dns/dns.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/vnet/dns/dns.h') diff --git a/src/vnet/dns/dns.h b/src/vnet/dns/dns.h index d5029e521d6..494ac672096 100644 --- a/src/vnet/dns/dns.h +++ b/src/vnet/dns/dns.h @@ -97,7 +97,7 @@ typedef struct /** Find cached record by name */ uword *cache_entry_by_name; - uword *cache_lock; + clib_spinlock_t cache_lock; /** enable / disable flag */ int is_enabled; @@ -196,8 +196,7 @@ dns_cache_lock (dns_main_t * dm) { if (dm->cache_lock) { - while (clib_atomic_test_and_set (dm->cache_lock)) - CLIB_PAUSE (); + clib_spinlock_lock (&dm->cache_lock); } } @@ -206,7 +205,7 @@ dns_cache_unlock (dns_main_t * dm) { if (dm->cache_lock) { - clib_atomic_release (dm->cache_lock); + clib_spinlock_unlock (&dm->cache_lock); } } -- cgit 1.2.3-korg