From e211ac4886d0ae51c08f77c76ed37b76f01f7629 Mon Sep 17 00:00:00 2001 From: Benoît Ganne Date: Tue, 21 Feb 2023 16:09:47 +0100 Subject: fib: fix load-balance and replicate dpos buckets overflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit load-balance and replicate dpos both store their number of buckets as u16, which can overflow if too many paths are configured. For load-balance it can happens quite quickly because of weights normalization. Type: fix Change-Id: I0c78c39fc3d40626dfc58b49e7d99d71f9852b50 Signed-off-by: Benoît Ganne --- src/vnet/dpo/load_balance.h | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'src/vnet/dpo/load_balance.h') diff --git a/src/vnet/dpo/load_balance.h b/src/vnet/dpo/load_balance.h index 5428e20e981..3605d82a207 100644 --- a/src/vnet/dpo/load_balance.h +++ b/src/vnet/dpo/load_balance.h @@ -49,6 +49,12 @@ typedef struct load_balance_main_t_ extern load_balance_main_t load_balance_main; +/** + * The maximum number of buckets that a load-balance object can have + * This must not overflow the lb_n_buckets field + */ +#define LB_MAX_BUCKETS 8192 + /** * The number of buckets that a load-balance object can have and still * fit in one cache-line @@ -176,6 +182,10 @@ typedef struct load_balance_t_ { STATIC_ASSERT(sizeof(load_balance_t) <= CLIB_CACHE_LINE_BYTES, "A load_balance object size exceeds one cacheline"); +STATIC_ASSERT (LB_MAX_BUCKETS <= CLIB_U16_MAX, + "Too many buckets for load_balance object"); +STATIC_ASSERT (LB_MAX_BUCKETS && !(LB_MAX_BUCKETS & (LB_MAX_BUCKETS - 1)), + "LB_MAX_BUCKETS must be a power of 2"); /** * Flags controlling load-balance formatting/display -- cgit 1.2.3-korg