From 7af4a57e7824c850f28a3cc5b4451a9e9baad068 Mon Sep 17 00:00:00 2001 From: Marco Varlese Date: Mon, 27 Nov 2017 16:46:04 +0100 Subject: Address COVERITY warnings Among many false positives the potential NULL pointer dereference seems to be a valid one hence addressing that with this patch. Change-Id: Ia55784475294e96f60df64baf8820b459bb85bb7 Signed-off-by: Marco Varlese --- src/vnet/geneve/encap.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/vnet/geneve') diff --git a/src/vnet/geneve/encap.c b/src/vnet/geneve/encap.c index 59d5c96c974..e9e7e5b9faf 100644 --- a/src/vnet/geneve/encap.c +++ b/src/vnet/geneve/encap.c @@ -153,6 +153,9 @@ geneve_encap_inline (vlib_main_t * vm, /* Note: change to always set next0 if it may be set to drop */ next0 = t0->next_dpo.dpoi_next_node; } + + ASSERT (t0 != NULL); + vnet_buffer (b0)->ip.adj_index[VLIB_TX] = t0->next_dpo.dpoi_index; /* Get next node index and adj index from tunnel next_dpo */ @@ -164,6 +167,9 @@ geneve_encap_inline (vlib_main_t * vm, /* Note: change to always set next1 if it may be set to drop */ next1 = t1->next_dpo.dpoi_next_node; } + + ASSERT (t1 != NULL); + vnet_buffer (b1)->ip.adj_index[VLIB_TX] = t1->next_dpo.dpoi_index; /* Apply the rewrite string. $$$$ vnet_rewrite? */ -- cgit 1.2.3-korg