From a50a14c5577e82866b05f325e359c86ba7145730 Mon Sep 17 00:00:00 2001 From: Mohsin Kazmi Date: Wed, 25 Apr 2018 15:58:05 +0200 Subject: itf: Fix admin up down for AF_PACKET and vhost-user Change-Id: I84327197d59c72d0d046dd2cb4071bf74af6fc28 Signed-off-by: Mohsin Kazmi --- src/vnet/interface.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'src/vnet/interface.c') diff --git a/src/vnet/interface.c b/src/vnet/interface.c index 36793f1177e..d85d864839e 100644 --- a/src/vnet/interface.c +++ b/src/vnet/interface.c @@ -485,10 +485,13 @@ vnet_sw_interface_set_flags_helper (vnet_main_t * vnm, u32 sw_if_index, error = call_elf_section_interface_callbacks (vnm, sw_if_index, flags, vnm->sw_interface_admin_up_down_functions); - si->flags = old_flags; if (error) - goto done; + { + /* restore flags on error */ + si->flags = old_flags; + goto done; + } if (si->type == VNET_SW_INTERFACE_TYPE_HARDWARE) { -- cgit 1.2.3-korg