From beafecfc2e183d8b4036894e345847ad1ab351a9 Mon Sep 17 00:00:00 2001 From: Vijayabhaskar Katamreddy Date: Thu, 19 May 2022 17:07:22 +0000 Subject: ip: reassembly - fixing stepping index in a better way Type: fix pool_is_free_index() check is performed only for the first element Signed-off-by: Vijayabhaskar Katamreddy Change-Id: Icadc715a9b54761ec69805a134a69a262137536d --- src/vnet/ip/reass/ip4_full_reass.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'src/vnet/ip') diff --git a/src/vnet/ip/reass/ip4_full_reass.c b/src/vnet/ip/reass/ip4_full_reass.c index 1ac22615a60..becfc460450 100644 --- a/src/vnet/ip/reass/ip4_full_reass.c +++ b/src/vnet/ip/reass/ip4_full_reass.c @@ -1724,14 +1724,14 @@ ip4_full_reass_walk_expired (vlib_main_t *vm, vlib_node_runtime_t *node, rt->last_id = end; } - pool_foreach_stepping_index ( - index, beg, end, rt->pool, ({ - reass = pool_elt_at_index (rt->pool, index); - if (now > reass->last_heard + rm->timeout) - { - vec_add1 (pool_indexes_to_free, index); - } - })); + pool_foreach_stepping_index (index, beg, end, rt->pool) + { + reass = pool_elt_at_index (rt->pool, index); + if (now > reass->last_heard + rm->timeout) + { + vec_add1 (pool_indexes_to_free, index); + } + } if (vec_len (pool_indexes_to_free)) vlib_node_increment_counter (vm, node->node_index, -- cgit 1.2.3-korg