From c2d476b26dead1097f120a2bf35cda904c4f55f9 Mon Sep 17 00:00:00 2001 From: Paul Atkins Date: Mon, 4 Oct 2021 16:29:52 +0100 Subject: ipfix-export: refactor params to the callback fns When a new flow-report is created the caller provides 2 callback functions. These functions both take a pointer to the exporter, plus a pointer to the source and dest address. However the pointers to the address are not adding any value as these are always set to the src/dest addresses of the exporter (which is already being passed). Remove these parameters and leave the callback functions to get the addresses out of the exporter. Type: improvement Signed-off-by: Paul Atkins Change-Id: I36dec394f30e85cdca120dd8706b5d90f5e07c48 --- src/vnet/ipfix-export/flow_report.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/vnet/ipfix-export/flow_report.h') diff --git a/src/vnet/ipfix-export/flow_report.h b/src/vnet/ipfix-export/flow_report.h index 6b884a2e28e..319533decac 100644 --- a/src/vnet/ipfix-export/flow_report.h +++ b/src/vnet/ipfix-export/flow_report.h @@ -56,13 +56,11 @@ typedef vlib_frame_t *(vnet_flow_data_callback_t) ( typedef u8 *(vnet_flow_rewrite_callback_t) (struct ipfix_exporter *exp, struct flow_report *, - ip4_address_t *, ip4_address_t *, u16, ipfix_report_element_t *elts, u32 n_elts, u32 *stream_index); u8 *vnet_flow_rewrite_generic_callback (struct ipfix_exporter *exp, - struct flow_report *, ip4_address_t *, - ip4_address_t *, u16, + struct flow_report *, u16, ipfix_report_element_t *elts, u32 n_elts, u32 *stream_index); -- cgit 1.2.3-korg