From 6631780422787166550b9871c46a94c160416324 Mon Sep 17 00:00:00 2001 From: John Lo Date: Tue, 13 Aug 2019 18:18:21 -0400 Subject: vlib: copy trace_handle in vlib_buffer_copy/clone() functions Since vlib_buffer_copy() and vlib_buffer_clone() both preserve VLIB_BUFFER_IS_TRACED bit in flags field, it should also copy trace_handle which would add minimal overhead. Thus, callers of these functions do not have to call vlib_buffer_copy_trace_flags() to copy trace_handle. Type: refactor Signed-off-by: John Lo Change-Id: Iff6a3f81660dd62b36a2966033eb380305340310 --- src/vnet/l2/l2_flood.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'src/vnet/l2/l2_flood.c') diff --git a/src/vnet/l2/l2_flood.c b/src/vnet/l2/l2_flood.c index 1bc528138d7..8d34233b520 100644 --- a/src/vnet/l2/l2_flood.c +++ b/src/vnet/l2/l2_flood.c @@ -250,9 +250,6 @@ VLIB_NODE_FN (l2flood_node) (vlib_main_t * vm, ethernet_header_t *h0; l2flood_trace_t *t; - if (c0 != b0) - vlib_buffer_copy_trace_flag (vm, b0, ci0); - t = vlib_add_trace (vm, node, c0, sizeof (*t)); h0 = vlib_buffer_get_current (c0); t->sw_if_index = sw_if_index0; @@ -301,9 +298,6 @@ VLIB_NODE_FN (l2flood_node) (vlib_main_t * vm, ethernet_header_t *h0; l2flood_trace_t *t; - if (c0 != b0) - vlib_buffer_copy_trace_flag (vm, b0, ci0); - t = vlib_add_trace (vm, node, c0, sizeof (*t)); h0 = vlib_buffer_get_current (c0); t->sw_if_index = sw_if_index0; -- cgit 1.2.3-korg