From d9360174483d3716886fa42f1b7041fc0cc79ef9 Mon Sep 17 00:00:00 2001
From: Steven Luong <sluong@cisco.com>
Date: Wed, 3 Mar 2021 16:56:19 -0800
Subject: l2: coverity woe in l2_rw_mod_entry

Coverity complains that the statement
 if (!e)
   return -1;
is never true and is logically dead code in the subject function. It is
right. e is assigned in both the if and else statementes immediately above
and can never be null.

Type: fix

Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: Ic2d0e76eff696ee689a68a07913876dcecf5c647
---
 src/vnet/l2/l2_rw.c | 3 ---
 1 file changed, 3 deletions(-)

(limited to 'src/vnet/l2/l2_rw.c')

diff --git a/src/vnet/l2/l2_rw.c b/src/vnet/l2/l2_rw.c
index a7c95fe1a77..b6de2faffc5 100644
--- a/src/vnet/l2/l2_rw.c
+++ b/src/vnet/l2/l2_rw.c
@@ -326,9 +326,6 @@ l2_rw_mod_entry (u32 * index,
       *index = e - rw->entries;
     }
 
-  if (!e)
-    return -1;
-
   if (is_del)
     {
       pool_put (rw->entries, e);
-- 
cgit 1.2.3-korg