From 18710d58f0dfae6c8455eedfe46545566e7ed4a8 Mon Sep 17 00:00:00 2001 From: Florin Coras Date: Tue, 28 Nov 2023 15:28:16 -0800 Subject: session: no reply on app del worker with sapi With socket api, applications should not expect reply after worker del msg. VCL in particular closes the socket after it enqueues the message. Found by ASAN. Type: fix Signed-off-by: Dmitry Valter Signed-off-by: Florin Coras Change-Id: I1be02a0cde6b96a96edb709f3fe30bbc01ff2d24 --- src/vnet/session/session_api.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/vnet/session/session_api.c') diff --git a/src/vnet/session/session_api.c b/src/vnet/session/session_api.c index ff49d2ac032..06edb82bdb3 100644 --- a/src/vnet/session/session_api.c +++ b/src/vnet/session/session_api.c @@ -1463,6 +1463,10 @@ sapi_add_del_worker_handler (app_namespace_t * app_ns, done: + /* With app sock api socket expected to be closed, no reply */ + if (!mp->is_add && appns_sapi_enabled ()) + return; + msg.type = APP_SAPI_MSG_TYPE_ADD_DEL_WORKER_REPLY; rmp = &msg.worker_add_del_reply; rmp->retval = rv; -- cgit 1.2.3-korg