From 71612d61930e57e7c8ebf9e5647b15a4b23720b2 Mon Sep 17 00:00:00 2001 From: Dave Wallace Date: Tue, 24 Oct 2017 01:32:41 -0400 Subject: Add extern to *_main global variable declarations in header files. - Global variables declared in header files without the use of the 'extern' keword will result in multiple instances of the variable to be created by the compiler -- one for each different source file in which the the header file is included. This results in wasted memory allocated in the BSS segments as well as potentially introducing bugs in the application. Change-Id: I6ef1790b60a0bd9dd3994f8510723decf258b0cc Signed-off-by: Dave Wallace --- src/vnet/snap/snap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/vnet/snap') diff --git a/src/vnet/snap/snap.h b/src/vnet/snap/snap.h index 7cd453e7a97..08c3a8b9c18 100644 --- a/src/vnet/snap/snap.h +++ b/src/vnet/snap/snap.h @@ -165,7 +165,7 @@ snap_get_protocol_info (snap_main_t * sm, snap_header_t * h) return p ? vec_elt_at_index (sm->protocols, p[0]) : 0; } -snap_main_t snap_main; +extern snap_main_t snap_main; /* Register given node index to take input for given snap type. */ void -- cgit 1.2.3-korg