From 4beb1c6643c1288aca8f2429ac380337458066c5 Mon Sep 17 00:00:00 2001 From: Ivan Shvedunov Date: Sat, 16 Jan 2021 03:43:01 +0300 Subject: tcp: remove bad assert Don't assume that half-open connections pending removal are always successful. Type: fix Signed-off-by: Ivan Shvedunov Change-Id: I955077a4ed2389b9ee38d97e27a7c7761c860a4a --- src/vnet/tcp/tcp_input.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src/vnet/tcp/tcp_input.c') diff --git a/src/vnet/tcp/tcp_input.c b/src/vnet/tcp/tcp_input.c index 0a3d31588ee..a159d850728 100644 --- a/src/vnet/tcp/tcp_input.c +++ b/src/vnet/tcp/tcp_input.c @@ -1812,13 +1812,10 @@ tcp46_syn_sent_inline (vlib_main_t * vm, vlib_node_runtime_t * node, goto drop; } - /* Half-open completed recently but the connection was't removed - * yet by the owning thread */ + /* Half-open completed or cancelled recently but the connection + * was't removed yet by the owning thread */ if (PREDICT_FALSE (tc0->flags & TCP_CONN_HALF_OPEN_DONE)) { - /* Make sure the connection actually exists */ - ASSERT (tcp_lookup_connection (tc0->c_fib_index, b0, - my_thread_index, is_ip4)); error0 = TCP_ERROR_SPURIOUS_SYN_ACK; goto drop; } -- cgit 1.2.3-korg