From ab46b6a03b9c416f6fafe0a11bf82a0297b2b498 Mon Sep 17 00:00:00 2001 From: Florin Coras Date: Mon, 4 Nov 2019 14:39:33 -0800 Subject: tcp: fix retransmit with no sacks Type: fix Change-Id: I6f7df0d358f57f7feadb9b7a3fcffb99558b2af8 Signed-off-by: Florin Coras (cherry picked from commit bf1f8b7f288c29bfcc128b1d09eae1c1eac2b7cc) --- src/vnet/tcp/tcp_output.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) (limited to 'src/vnet/tcp/tcp_output.c') diff --git a/src/vnet/tcp/tcp_output.c b/src/vnet/tcp/tcp_output.c index 2437b7bf28f..620d19b21c3 100644 --- a/src/vnet/tcp/tcp_output.c +++ b/src/vnet/tcp/tcp_output.c @@ -1960,8 +1960,8 @@ tcp_retransmit_sack (tcp_worker_ctx_t * wrk, tcp_connection_t * tc, && tc->rxt_head != tc->snd_una && tcp_retransmit_should_retry_head (tc, sb)) { - n_written = tcp_prepare_retransmit_segment (wrk, tc, 0, tc->snd_mss, - &b); + max_bytes = clib_min (tc->snd_mss, tc->snd_congestion - tc->snd_una); + n_written = tcp_prepare_retransmit_segment (wrk, tc, 0, max_bytes, &b); if (!n_written) { tcp_program_retransmit (tc); @@ -2087,7 +2087,7 @@ static int tcp_retransmit_no_sack (tcp_worker_ctx_t * wrk, tcp_connection_t * tc, u32 burst_size) { - u32 n_written = 0, offset = 0, bi, max_deq, n_segs_now; + u32 n_written = 0, offset = 0, bi, max_deq, n_segs_now, max_bytes; u32 burst_bytes, sent_bytes; vlib_main_t *vm = wrk->vm; int snd_space, n_segs = 0; @@ -2095,7 +2095,7 @@ tcp_retransmit_no_sack (tcp_worker_ctx_t * wrk, tcp_connection_t * tc, vlib_buffer_t *b; u64 time_now; - ASSERT (tcp_in_fastrecovery (tc)); + ASSERT (tcp_in_cong_recovery (tc)); TCP_EVT (TCP_EVT_CC_EVT, tc, 0); time_now = wrk->vm->clib_time.last_cpu_time; @@ -2118,8 +2118,12 @@ tcp_retransmit_no_sack (tcp_worker_ctx_t * wrk, tcp_connection_t * tc, * segment. */ while (snd_space > 0 && n_segs < burst_size) { - n_written = tcp_prepare_retransmit_segment (wrk, tc, offset, - tc->snd_mss, &b); + max_bytes = clib_min (tc->snd_mss, + tc->snd_congestion - tc->snd_una - offset); + if (!max_bytes) + break; + n_written = tcp_prepare_retransmit_segment (wrk, tc, offset, max_bytes, + &b); /* Nothing left to retransmit */ if (n_written == 0) @@ -2148,7 +2152,7 @@ send_unsent: snd_space = clib_min (max_deq, snd_space); burst_size = clib_min (burst_size - n_segs, snd_space / tc->snd_mss); n_segs_now = tcp_transmit_unsent (wrk, tc, burst_size); - if (max_deq > n_segs_now * tc->snd_mss) + if (n_segs_now && max_deq > n_segs_now * tc->snd_mss) tcp_program_retransmit (tc); n_segs += n_segs_now; } -- cgit 1.2.3-korg