From c3148b1be8f519c80c4417c21b978dfef72b351b Mon Sep 17 00:00:00 2001 From: Damjan Marion Date: Tue, 12 Mar 2024 17:42:49 +0100 Subject: misc: remove GNU Indent directives Type: refactor Change-Id: I5235bf3e9aff58af6ba2c14e8c6529c4fc9ec86c Signed-off-by: Damjan Marion --- src/vppinfra/bihash_template.c | 2 -- src/vppinfra/bihash_template.h | 8 -------- src/vppinfra/bitmap.h | 8 -------- src/vppinfra/byte_order.h | 2 -- src/vppinfra/crypto/aes.h | 2 -- src/vppinfra/elf.c | 2 -- src/vppinfra/hash.c | 4 ---- src/vppinfra/macros.c | 4 ---- src/vppinfra/mem_dlmalloc.c | 2 -- src/vppinfra/pmalloc.c | 2 -- src/vppinfra/random_buffer.h | 4 ---- src/vppinfra/test_fifo.c | 2 -- src/vppinfra/test_hash.c | 4 ---- src/vppinfra/test_pool_iterate.c | 2 -- src/vppinfra/test_tw_timer.c | 32 -------------------------------- src/vppinfra/timing_wheel.c | 12 ------------ src/vppinfra/vector_avx2.h | 6 ------ src/vppinfra/vector_avx512.h | 6 ------ src/vppinfra/vector_neon.h | 2 -- src/vppinfra/vector_sse42.h | 4 ---- 20 files changed, 110 deletions(-) (limited to 'src/vppinfra') diff --git a/src/vppinfra/bihash_template.c b/src/vppinfra/bihash_template.c index 8094321bc89..d488b1a659c 100644 --- a/src/vppinfra/bihash_template.c +++ b/src/vppinfra/bihash_template.c @@ -700,12 +700,10 @@ static_always_inline int BV (clib_bihash_add_del_inline_with_hash) ( int mark_bucket_linear; int resplit_once; - /* *INDENT-OFF* */ static const BVT (clib_bihash_bucket) mask = { .linear_search = 1, .log2_pages = -1 }; - /* *INDENT-ON* */ #if BIHASH_LAZY_INSTANTIATE /* diff --git a/src/vppinfra/bihash_template.h b/src/vppinfra/bihash_template.h index e8a2c01cece..8f5879b4634 100644 --- a/src/vppinfra/bihash_template.h +++ b/src/vppinfra/bihash_template.h @@ -99,7 +99,6 @@ typedef struct STATIC_ASSERT_SIZEOF (BVT (clib_bihash_bucket), sizeof (u64)); -/* *INDENT-OFF* */ typedef CLIB_PACKED (struct { /* * Backing store allocation. Since bihash manages its own @@ -118,7 +117,6 @@ typedef CLIB_PACKED (struct { volatile u32 ready; u64 pad[1]; }) BVT (clib_bihash_shared_header); -/* *INDENT-ON* */ STATIC_ASSERT_SIZEOF (BVT (clib_bihash_shared_header), 8 * sizeof (u64)); @@ -282,9 +280,7 @@ static inline void BV (clib_bihash_alloc_unlock) (BVT (clib_bihash) * h) static inline void BV (clib_bihash_lock_bucket) (BVT (clib_bihash_bucket) * b) { - /* *INDENT-OFF* */ BVT (clib_bihash_bucket) mask = { .lock = 1 }; - /* *INDENT-ON* */ u64 old; try_again: @@ -415,12 +411,10 @@ static inline int BV (clib_bihash_search_inline_with_hash) BVT (clib_bihash_bucket) * b; int i, limit; - /* *INDENT-OFF* */ static const BVT (clib_bihash_bucket) mask = { .linear_search = 1, .log2_pages = -1 }; - /* *INDENT-ON* */ #if BIHASH_LAZY_INSTANTIATE if (PREDICT_FALSE (h->instantiated == 0)) @@ -518,12 +512,10 @@ static inline int BV (clib_bihash_search_inline_2_with_hash) BVT (clib_bihash_bucket) * b; int i, limit; -/* *INDENT-OFF* */ static const BVT (clib_bihash_bucket) mask = { .linear_search = 1, .log2_pages = -1 }; -/* *INDENT-ON* */ ASSERT (valuep); diff --git a/src/vppinfra/bitmap.h b/src/vppinfra/bitmap.h index 99d65954d09..4ab7bcf7a7c 100644 --- a/src/vppinfra/bitmap.h +++ b/src/vppinfra/bitmap.h @@ -546,12 +546,10 @@ always_inline uword *clib_bitmap_xor (uword * ai, uword * bi); } /* ALU functions: */ -/* *INDENT-OFF* */ _(and, a = a & b, 1) _(andnot, a = a & ~b, 1) _(or, a = a | b, 0) _(xor, a = a ^ b, 1) -/* *INDENT-ON* */ #undef _ /** Logical operator across two bitmaps which duplicates the first bitmap @@ -590,12 +588,10 @@ always_inline uword *clib_bitmap_dup_xor (uword * ai, uword * bi); clib_bitmap_dup_##name (uword * ai, uword * bi) \ { return clib_bitmap_##name (clib_bitmap_dup (ai), bi); } -/* *INDENT-OFF* */ _(and); _(andnot); _(or); _(xor); -/* *INDENT-ON* */ #undef _ /* ALU function definition macro for functions taking one bitmap and an @@ -618,12 +614,10 @@ clib_bitmap_##name (uword * ai, uword i) \ } /* ALU functions immediate: */ -/* *INDENT-OFF* */ _(andi, a = a & b, 1) _(andnoti, a = a & ~b, 1) _(ori, a = a | b, 0) _(xori, a = a ^ b, 1) -/* *INDENT-ON* */ #undef _ /* ALU function definition macro for functions taking one bitmap and an @@ -644,13 +638,11 @@ clib_bitmap_##name##_notrim (uword * ai, uword i) \ } /* ALU functions immediate: */ -/* *INDENT-OFF* */ _(andi, a = a & b) _(andnoti, a = a & ~b) _(ori, a = a | b) _(xori, a = a ^ b) #undef _ -/* *INDENT-ON* */ /** Return a random bitmap of the requested length @param ai - pointer to the destination bitmap diff --git a/src/vppinfra/byte_order.h b/src/vppinfra/byte_order.h index 9beb4470634..7bc26002a2f 100644 --- a/src/vppinfra/byte_order.h +++ b/src/vppinfra/byte_order.h @@ -173,12 +173,10 @@ _(i64); #undef _ /* Dummy endian swap functions for IEEE floating-point numbers */ -/* *INDENT-OFF* */ always_inline f64 clib_net_to_host_f64 (f64 x) { return x; } always_inline f64 clib_host_to_net_f64 (f64 x) { return x; } always_inline f32 clib_net_to_host_f32 (f32 x) { return x; } always_inline f32 clib_host_to_net_f32 (f32 x) { return x; } -/* *INDENT-ON* */ #endif /* included_clib_byte_order_h */ diff --git a/src/vppinfra/crypto/aes.h b/src/vppinfra/crypto/aes.h index 0aa154187a8..9e80e3b0318 100644 --- a/src/vppinfra/crypto/aes.h +++ b/src/vppinfra/crypto/aes.h @@ -199,9 +199,7 @@ aes192_key_expand (u8x16 * rk, u8x16u const *k) u8x16 r1, r2; rk[0] = r1 = k[0]; - /* *INDENT-OFF* */ rk[1] = r2 = (u8x16) (u64x2) { *(u64 *) (k + 1), 0 }; - /* *INDENT-ON* */ aes192_key_assist (&r1, &r2, aes_keygen_assist (r2, 0x1)); rk[1] = (u8x16) _mm_shuffle_pd ((__m128d) rk[1], (__m128d) r1, 0); diff --git a/src/vppinfra/elf.c b/src/vppinfra/elf.c index af0b2b8cb6f..f660195e101 100644 --- a/src/vppinfra/elf.c +++ b/src/vppinfra/elf.c @@ -1702,7 +1702,6 @@ layout_sections (elf_main_t * em) continue; s_lo = s_hi = 0; - /* *INDENT-OFF* */ clib_bitmap_foreach (si, g->section_index_bitmap) { u64 lo, hi; @@ -1727,7 +1726,6 @@ layout_sections (elf_main_t * em) s_hi = hi; } } - /* *INDENT-ON* */ if (n_sections == 0) continue; diff --git a/src/vppinfra/hash.c b/src/vppinfra/hash.c index 76f71d37d19..0e650e67a90 100644 --- a/src/vppinfra/hash.c +++ b/src/vppinfra/hash.c @@ -628,11 +628,9 @@ hash_resize_internal (void *old, uword new_size, uword free_old) { hash_t *h = old ? hash_header (old) : 0; new = _hash_create (new_size, h); - /* *INDENT-OFF* */ hash_foreach_pair (p, old, { new = _hash_set3 (new, p->key, &p->value[0], 0); }); - /* *INDENT-ON* */ } if (free_old) @@ -884,11 +882,9 @@ format_hash (u8 *s, va_list *va) if (verbose) { - /* *INDENT-OFF* */ hash_foreach_pair (p, v, { s = format (s, " %U\n", h->format_pair, h->format_pair_arg, v, p); }); - /* *INDENT-ON* */ } return s; diff --git a/src/vppinfra/macros.c b/src/vppinfra/macros.c index 27a92a8abe2..b8644b2738e 100644 --- a/src/vppinfra/macros.c +++ b/src/vppinfra/macros.c @@ -251,13 +251,11 @@ clib_macro_free (clib_macro_main_t * mm) hash_free (mm->the_builtin_eval_hash); - /* *INDENT-OFF* */ hash_foreach_pair (p, mm->the_value_table_hash, ({ vec_add1 (strings_to_free, (u8 *) (p->key)); vec_add1 (strings_to_free, (u8 *) (p->value[0])); })); - /* *INDENT-ON* */ for (i = 0; i < vec_len (strings_to_free); i++) vec_free (strings_to_free[i]); @@ -290,14 +288,12 @@ format_clib_macro_main (u8 * s, va_list * args) name_sort_t *nses = 0, *ns; int i; - /* *INDENT-OFF* */ hash_foreach_pair (p, mm->the_value_table_hash, ({ vec_add2 (nses, ns, 1); ns->name = (u8 *)(p->key); ns->value = (u8 *)(p->value[0]); })); - /* *INDENT-ON* */ if (vec_len (nses) == 0) return s; diff --git a/src/vppinfra/mem_dlmalloc.c b/src/vppinfra/mem_dlmalloc.c index de7591139ca..a188164a7ba 100644 --- a/src/vppinfra/mem_dlmalloc.c +++ b/src/vppinfra/mem_dlmalloc.c @@ -117,14 +117,12 @@ mheap_get_trace_internal (const clib_mem_heap_t *heap, uword offset, { hash_pair_t *p; mheap_trace_t *q; - /* *INDENT-OFF* */ hash_foreach_pair (p, tm->trace_by_callers, ({ q = uword_to_pointer (p->key, mheap_trace_t *); ASSERT (q >= old_start && q < old_end); p->key = pointer_to_uword (tm->traces + (q - old_start)); })); - /* *INDENT-ON* */ } trace_index = t - tm->traces; } diff --git a/src/vppinfra/pmalloc.c b/src/vppinfra/pmalloc.c index 9fb8ac4dcfe..ff392a1bf22 100644 --- a/src/vppinfra/pmalloc.c +++ b/src/vppinfra/pmalloc.c @@ -631,7 +631,6 @@ format_pmalloc (u8 * s, va_list * va) format_clib_error, pm->error); - /* *INDENT-OFF* */ pool_foreach (a, pm->arenas) { u32 *page_index; @@ -649,7 +648,6 @@ format_pmalloc (u8 * s, va_list * va) format_pmalloc_page, pp, verbose); } } - /* *INDENT-ON* */ return s; } diff --git a/src/vppinfra/random_buffer.h b/src/vppinfra/random_buffer.h index 83e6bcef479..12343c10535 100644 --- a/src/vppinfra/random_buffer.h +++ b/src/vppinfra/random_buffer.h @@ -42,9 +42,7 @@ #include #include -/* *INDENT-OFF* */ WARN_OFF(array-bounds) -/* *INDENT-ON* */ typedef struct { @@ -120,9 +118,7 @@ clib_random_buffer_get_data (clib_random_buffer_t * b, uword n_bytes) return b->buffer + i; } -/* *INDENT-OFF* */ WARN_ON(array-bounds) -/* *INDENT-ON* */ #endif /* included_clib_random_buffer_h */ diff --git a/src/vppinfra/test_fifo.c b/src/vppinfra/test_fifo.c index 45392bc35eb..2d3cad33119 100644 --- a/src/vppinfra/test_fifo.c +++ b/src/vppinfra/test_fifo.c @@ -105,12 +105,10 @@ test_fifo_main (unformat_input_t * input) ASSERT (clib_fifo_elts (as) == n_added - n_removed); j = 0; - /* *INDENT-OFF* */ clib_fifo_foreach (a, as, { ASSERT (A_is_valid (a, n_removed + j)); j++; }); - /* *INDENT-ON* */ ASSERT (j == clib_fifo_elts (as)); } diff --git a/src/vppinfra/test_hash.c b/src/vppinfra/test_hash.c index 95ced448c13..25adff3443b 100644 --- a/src/vppinfra/test_hash.c +++ b/src/vppinfra/test_hash.c @@ -86,14 +86,12 @@ hash_next_test (word * h) hash_pair_t *p0, *p1; clib_error_t *error = 0; - /* *INDENT-OFF* */ hash_foreach_pair (p0, h, { p1 = hash_next (h, &hn); error = CLIB_ERROR_ASSERT (p0 == p1); if (error) break; }); - /* *INDENT-ON* */ if (!error) error = CLIB_ERROR_ASSERT (!hash_next (h, &hn)); @@ -176,12 +174,10 @@ test_word_key (hash_test_t * ht) hash_pair_t *p; uword ki; - /* *INDENT-OFF* */ hash_foreach_pair (p, h, { ki = p->value[0]; ASSERT (keys[ki] == p->key); }); - /* *INDENT-ON* */ } if ((error = hash_validate (h))) diff --git a/src/vppinfra/test_pool_iterate.c b/src/vppinfra/test_pool_iterate.c index bcbd235ba71..fc4be6d6fe1 100644 --- a/src/vppinfra/test_pool_iterate.c +++ b/src/vppinfra/test_pool_iterate.c @@ -77,7 +77,6 @@ main (int argc, char *argv[]) } while (next != ~0); - /* *INDENT-OFF* */ pool_foreach (junk, tp) { int is_free; @@ -94,7 +93,6 @@ main (int argc, char *argv[]) clib_warning ("oops, busy index %d reported free", i); } } - /* *INDENT-ON* */ return 0; } diff --git a/src/vppinfra/test_tw_timer.c b/src/vppinfra/test_tw_timer.c index 47e5e49bf1f..e9f4251a7b1 100644 --- a/src/vppinfra/test_tw_timer.c +++ b/src/vppinfra/test_tw_timer.c @@ -316,7 +316,6 @@ test2_single (tw_timer_test_main_t * tm) j = 0; vec_reset_length (deleted_indices); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { tw_timer_stop_2t_1w_2048sl (&tm->single_wheel, e->stop_timer_handle); @@ -324,7 +323,6 @@ test2_single (tw_timer_test_main_t * tm) if (++j >= tm->ntimers / 4) goto del_and_re_add; } - /* *INDENT-ON* */ del_and_re_add: for (j = 0; j < vec_len (deleted_indices); j++) @@ -374,14 +372,12 @@ test2_single (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { fformat (stdout, "[%d] expected to expire %d\n", e - tm->test_elts, e->expected_to_expire); } - /* *INDENT-ON* */ pool_free (tm->test_elts); tw_timer_wheel_free_2t_1w_2048sl (&tm->single_wheel); @@ -455,7 +451,6 @@ test2_double (tw_timer_test_main_t * tm) j = 0; vec_reset_length (deleted_indices); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { tw_timer_stop_16t_2w_512sl (&tm->double_wheel, e->stop_timer_handle); @@ -463,7 +458,6 @@ test2_double (tw_timer_test_main_t * tm) if (++j >= tm->ntimers / 4) goto del_and_re_add; } - /* *INDENT-ON* */ del_and_re_add: for (j = 0; j < vec_len (deleted_indices); j++) @@ -512,14 +506,12 @@ test2_double (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { fformat (stdout, "[%d] expected to expire %d\n", e - tm->test_elts, e->expected_to_expire); } - /* *INDENT-ON* */ pool_free (tm->test_elts); tw_timer_wheel_free_16t_2w_512sl (&tm->double_wheel); @@ -590,7 +582,6 @@ test2_double_updates (tw_timer_test_main_t * tm) j = 0; - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { expiration_time = get_expiration_time (tm); @@ -602,7 +593,6 @@ test2_double_updates (tw_timer_test_main_t * tm) if (++j >= tm->ntimers / 4) goto done; } - /* *INDENT-ON* */ done: updates += j; @@ -623,14 +613,12 @@ test2_double_updates (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { fformat (stdout, "[%d] expected to expire %d\n", e - tm->test_elts, e->expected_to_expire); } - /* *INDENT-ON* */ pool_free (tm->test_elts); tw_timer_wheel_free_16t_2w_512sl (&tm->double_wheel); @@ -706,7 +694,6 @@ test2_triple (tw_timer_test_main_t * tm) j = 0; vec_reset_length (deleted_indices); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { tw_timer_stop_4t_3w_256sl (&tm->triple_wheel, e->stop_timer_handle); @@ -714,7 +701,6 @@ test2_triple (tw_timer_test_main_t * tm) if (++j >= tm->ntimers / 4) goto del_and_re_add; } - /* *INDENT-ON* */ del_and_re_add: for (j = 0; j < vec_len (deleted_indices); j++) @@ -763,14 +749,12 @@ test2_triple (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { fformat (stdout, "[%d] expected to expire %d\n", e - tm->test_elts, e->expected_to_expire); } - /* *INDENT-ON* */ pool_free (tm->test_elts); tw_timer_wheel_free_4t_3w_256sl (&tm->triple_wheel); @@ -846,7 +830,6 @@ test2_triple_ov (tw_timer_test_main_t * tm) j = 0; vec_reset_length (deleted_indices); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { tw_timer_stop_1t_3w_1024sl_ov (&tm->triple_ov_wheel, @@ -855,7 +838,6 @@ test2_triple_ov (tw_timer_test_main_t * tm) if (++j >= tm->ntimers / 4) goto del_and_re_add; } - /* *INDENT-ON* */ del_and_re_add: for (j = 0; j < vec_len (deleted_indices); j++) @@ -904,7 +886,6 @@ test2_triple_ov (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { TWT (tw_timer) * t; @@ -915,7 +896,6 @@ test2_triple_ov (tw_timer_test_main_t * tm) t = pool_elt_at_index (tm->triple_ov_wheel.timers, e->stop_timer_handle); fformat (stdout, " expiration_time %lld\n", t->expiration_time); } - /* *INDENT-ON* */ pool_free (tm->test_elts); tw_timer_wheel_free_1t_3w_1024sl_ov (&tm->triple_ov_wheel); @@ -972,14 +952,12 @@ test1_single (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { fformat(stdout, "[%d] expected to expire %d\n", e - tm->test_elts, e->expected_to_expire); } - /* *INDENT-ON* */ fformat (stdout, "final wheel time %d, fast index %d\n", @@ -1030,14 +1008,12 @@ test1_double (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { fformat(stdout, "[%d] expected to expire %d\n", e - tm->test_elts, e->expected_to_expire); } - /* *INDENT-ON* */ fformat (stdout, "final wheel time %d, fast index %d\n", @@ -1088,14 +1064,12 @@ test1_two_timer_double (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { fformat(stdout, "[%d] expected to expire %d\n", e - tm->test_elts, e->expected_to_expire); } - /* *INDENT-ON* */ fformat (stdout, "final wheel time %d, fast index %d\n", @@ -1168,14 +1142,12 @@ test3_triple_double (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { fformat (stdout, "[%d] expected to expire %d\n", e - tm->test_elts, e->expected_to_expire); } - /* *INDENT-ON* */ pool_free (tm->test_elts); tw_timer_wheel_free_4t_3w_256sl (&tm->triple_wheel); @@ -1252,14 +1224,12 @@ test4_double_double (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { fformat (stdout, "[%d] expected to expire %d\n", e - tm->test_elts, e->expected_to_expire); } - /* *INDENT-ON* */ pool_free (tm->test_elts); tw_timer_wheel_free_16t_2w_512sl (&tm->double_wheel); @@ -1336,14 +1306,12 @@ test5_double (tw_timer_test_main_t * tm) fformat (stdout, "Note: %d elements remain in pool\n", pool_elts (tm->test_elts)); - /* *INDENT-OFF* */ pool_foreach (e, tm->test_elts) { fformat (stdout, "[%d] expected to expire %d\n", e - tm->test_elts, e->expected_to_expire); } - /* *INDENT-ON* */ pool_free (tm->test_elts); tw_timer_wheel_free_16t_2w_512sl (&tm->double_wheel); diff --git a/src/vppinfra/timing_wheel.c b/src/vppinfra/timing_wheel.c index edd878239cf..830888a19c1 100644 --- a/src/vppinfra/timing_wheel.c +++ b/src/vppinfra/timing_wheel.c @@ -302,23 +302,19 @@ timing_wheel_insert (timing_wheel_t * w, u64 insert_cpu_time, u32 user_data) /* Delete elts with given user data so that stale events don't expire. */ vec_foreach (l, w->levels) { - /* *INDENT-OFF* */ clib_bitmap_foreach (wi, l->occupancy_bitmap) { l->elts[wi] = delete_user_data (l->elts[wi], user_data); if (vec_len (l->elts[wi]) == 0) l->occupancy_bitmap = clib_bitmap_andnoti (l->occupancy_bitmap, wi); } - /* *INDENT-ON* */ } { timing_wheel_overflow_elt_t *oe; - /* *INDENT-OFF* */ pool_foreach (oe, w->overflow_pool) { if (oe->user_data == user_data) pool_put (w->overflow_pool, oe); } - /* *INDENT-ON* */ } hash_unset (w->deleted_user_data_hash, user_data); @@ -397,10 +393,8 @@ timing_wheel_next_expiring_elt_time (timing_wheel_t * w) if (min_dt != ~0) min_t = w->cpu_time_base + min_dt; - /* *INDENT-OFF* */ pool_foreach (oe, w->overflow_pool) { min_t = clib_min (min_t, oe->cpu_time); } - /* *INDENT-ON* */ done: return min_t; @@ -485,7 +479,6 @@ advance_cpu_time_base (timing_wheel_t * w, u32 * expired_user_data) vec_foreach (l, w->levels) { uword wi; - /* *INDENT-OFF* */ clib_bitmap_foreach (wi, l->occupancy_bitmap) { vec_foreach (e, l->elts[wi]) { @@ -496,13 +489,11 @@ advance_cpu_time_base (timing_wheel_t * w, u32 * expired_user_data) e->cpu_time_relative_to_base -= delta; } } - /* *INDENT-ON* */ } /* See which overflow elements fit now. */ { timing_wheel_overflow_elt_t *oe; - /* *INDENT-OFF* */ pool_foreach (oe, w->overflow_pool) { /* It fits now into 32 bits. */ if (0 == ((oe->cpu_time - w->cpu_time_base) >> BITS (e->cpu_time_relative_to_base))) @@ -521,7 +512,6 @@ advance_cpu_time_base (timing_wheel_t * w, u32 * expired_user_data) pool_put (w->overflow_pool, oe); } } - /* *INDENT-ON* */ } return expired_user_data; } @@ -647,12 +637,10 @@ timing_wheel_advance (timing_wheel_t * w, u64 advance_cpu_time, break; level = vec_elt_at_index (w->levels, level_index); - /* *INDENT-OFF* */ clib_bitmap_foreach (wi, level->occupancy_bitmap) { expired_user_data = expire_bin (w, level_index, wi, advance_cpu_time, expired_user_data); } - /* *INDENT-ON* */ } if (PREDICT_TRUE (level_index < vec_len (w->levels))) diff --git a/src/vppinfra/vector_avx2.h b/src/vppinfra/vector_avx2.h index b832681632c..866c82fcec3 100644 --- a/src/vppinfra/vector_avx2.h +++ b/src/vppinfra/vector_avx2.h @@ -19,7 +19,6 @@ #include #include -/* *INDENT-OFF* */ #define foreach_avx2_vec256i \ _(i,8,32,epi8) _(i,16,16,epi16) _(i,32,8,epi32) _(i,64,4,epi64) #define foreach_avx2_vec256u \ @@ -67,7 +66,6 @@ t##s##x##c##_interleave_hi (t##s##x##c a, t##s##x##c b) \ foreach_avx2_vec256i foreach_avx2_vec256u #undef _ -/* *INDENT-ON* */ always_inline u32x8 u32x8_permute (u32x8 v, u32x8 idx) @@ -80,7 +78,6 @@ u32x8_permute (u32x8 v, u32x8 idx) (__m256i) v, ((m0) | (m1) << 2 | (m2) << 4 | (m3) << 6)) /* _extract_lo, _extract_hi */ -/* *INDENT-OFF* */ #define _(t1,t2) \ always_inline t1 \ t2##_extract_lo (t2 v) \ @@ -103,7 +100,6 @@ _(u16x8, u16x16) _(u32x4, u32x8) _(u64x2, u64x4) #undef _ -/* *INDENT-ON* */ /* 256 bit packs. */ #define _(f, t, fn) \ @@ -132,7 +128,6 @@ i8x32_msb_mask (i8x32 v) } /* _from_ */ -/* *INDENT-OFF* */ #define _(f,t,i) \ static_always_inline t \ t##_from_##f (f x) \ @@ -151,7 +146,6 @@ _ (i8x16, i16x16, epi8_epi16) _(i8x16, i32x8, epi8_epi32) _(i8x16, i64x4, epi8_epi64) #undef _ -/* *INDENT-ON* */ static_always_inline u64x4 u64x4_byte_swap (u64x4 v) diff --git a/src/vppinfra/vector_avx512.h b/src/vppinfra/vector_avx512.h index f15a04ec128..699afec1212 100644 --- a/src/vppinfra/vector_avx512.h +++ b/src/vppinfra/vector_avx512.h @@ -19,7 +19,6 @@ #include #include -/* *INDENT-OFF* */ #define foreach_avx512_vec512i \ _(i,8,64,epi8) _(i,16,32,epi16) _(i,32,16,epi32) _(i,64,8,epi64) #define foreach_avx512_vec512u \ @@ -91,7 +90,6 @@ foreach_avx512_vec512i foreach_avx512_vec512u #undef _ -/* *INDENT-ON* */ static_always_inline u32 u16x32_msb_mask (u16x32 v) @@ -479,12 +477,10 @@ u32x16_transpose (u32x16 m[16]) { __m512i r[16], a, b, c, d, x, y; - /* *INDENT-OFF* */ __m512i pm1 = (__m512i) (u64x8) { 0, 1, 8, 9, 4, 5, 12, 13}; __m512i pm2 = (__m512i) (u64x8) { 2, 3, 10, 11, 6, 7, 14, 15}; __m512i pm3 = (__m512i) (u64x8) { 0, 1, 2, 3, 8, 9, 10, 11}; __m512i pm4 = (__m512i) (u64x8) { 4, 5, 6, 7, 12, 13, 14, 15}; - /* *INDENT-ON* */ r[0] = _mm512_unpacklo_epi32 ((__m512i) m[0], (__m512i) m[1]); r[1] = _mm512_unpacklo_epi32 ((__m512i) m[2], (__m512i) m[3]); @@ -564,12 +560,10 @@ u64x8_transpose (u64x8 m[8]) { __m512i r[8], x, y; - /* *INDENT-OFF* */ __m512i pm1 = (__m512i) (u64x8) { 0, 1, 8, 9, 4, 5, 12, 13}; __m512i pm2 = (__m512i) (u64x8) { 2, 3, 10, 11, 6, 7, 14, 15}; __m512i pm3 = (__m512i) (u64x8) { 0, 1, 2, 3, 8, 9, 10, 11}; __m512i pm4 = (__m512i) (u64x8) { 4, 5, 6, 7, 12, 13, 14, 15}; - /* *INDENT-ON* */ r[0] = _mm512_unpacklo_epi64 ((__m512i) m[0], (__m512i) m[1]); r[1] = _mm512_unpacklo_epi64 ((__m512i) m[2], (__m512i) m[3]); diff --git a/src/vppinfra/vector_neon.h b/src/vppinfra/vector_neon.h index 70a7bc0f11e..48644ddbd98 100644 --- a/src/vppinfra/vector_neon.h +++ b/src/vppinfra/vector_neon.h @@ -43,7 +43,6 @@ u8x16_compare_byte_mask (u8x16 v) return (u32) (vgetq_lane_u64 (x64, 0) + (vgetq_lane_u64 (x64, 1) << 8)); } -/* *INDENT-OFF* */ #define foreach_neon_vec128i \ _(i,8,16,s8) _(i,16,8,s16) _(i,32,4,s32) _(i,64,2,s64) #define foreach_neon_vec128u \ @@ -109,7 +108,6 @@ u8x16_compare_byte_mask (u8x16 v) foreach_neon_vec128i foreach_neon_vec128u #undef _ -/* *INDENT-ON* */ static_always_inline u16x8 u16x8_byte_swap (u16x8 v) diff --git a/src/vppinfra/vector_sse42.h b/src/vppinfra/vector_sse42.h index 7c8e6255385..58d5da90125 100644 --- a/src/vppinfra/vector_sse42.h +++ b/src/vppinfra/vector_sse42.h @@ -41,7 +41,6 @@ #include /* for ASSERT */ #include -/* *INDENT-OFF* */ #define foreach_sse42_vec128i \ _(i,8,16,epi8) _(i,16,8,epi16) _(i,32,4,epi32) _(i,64,2,epi64x) #define foreach_sse42_vec128u \ @@ -92,7 +91,6 @@ t##s##x##c##_max (t##s##x##c a, t##s##x##c b) \ _(i,8,16,epi8) _(i,16,8,epi16) _(i,32,4,epi32) _(i,64,2,epi64) _(u,8,16,epu8) _(u,16,8,epu16) _(u,32,4,epu32) _(u,64,2,epu64) #undef _ -/* *INDENT-ON* */ #define CLIB_VEC128_SPLAT_DEFINED #define CLIB_HAVE_VEC128_UNALIGNED_LOAD_STORE @@ -412,7 +410,6 @@ u32x4_sum_elts (u32x4 sum4) } /* _from_ */ -/* *INDENT-OFF* */ #define _(f,t,i) \ static_always_inline t \ t##_from_##f (f x) \ @@ -432,7 +429,6 @@ _(i16x8, i32x4, epi16_epi32) _(i16x8, i64x2, epi16_epi64) _(i32x4, i64x2, epi32_epi64) #undef _ -/* *INDENT-ON* */ static_always_inline u64x2 u64x2_gather (void *p0, void *p1) -- cgit 1.2.3-korg