From 06f328129a01276858fff1086215478fa106dd8e Mon Sep 17 00:00:00 2001 From: Andrew Yourtchenko Date: Thu, 14 Jan 2021 10:19:08 +0000 Subject: tests: add generalized tags for tests, use them for run-solo tests We have accumulated several scenarios in prod or wishlists where it would be useful to have a general infra to say yes/no about a certain test, and potentially make decisions based on that, for example: - runs solo (aka 'time-dependent') - (wishlist) part of quick smoke-test set - (wishlist) intermittent failure unrelated to timing - (wishlist) test broken with a multi-worker config in vpp Refactor the current "run-solo" code to allow for this extension. Type: test Change-Id: Ia5b3810e57c0543753c8e0dc4dc0cfb4a30b36ac Signed-off-by: Andrew Yourtchenko Signed-off-by: Klement Sekera --- src/plugins/dhcp/test/test_dhcp.py | 6 ++---- src/plugins/dhcp/test/test_dhcp6.py | 6 ++---- src/plugins/flowprobe/test/test_flowprobe.py | 6 ++---- src/plugins/memif/test/test_memif.py | 6 ++---- src/vnet/bfd/test/test_bfd.py | 31 +++++++--------------------- 5 files changed, 15 insertions(+), 40 deletions(-) (limited to 'src') diff --git a/src/plugins/dhcp/test/test_dhcp.py b/src/plugins/dhcp/test/test_dhcp.py index 266932c3830..e17b0049df7 100644 --- a/src/plugins/dhcp/test/test_dhcp.py +++ b/src/plugins/dhcp/test/test_dhcp.py @@ -6,6 +6,7 @@ import struct import six from framework import VppTestCase, VppTestRunner, running_extended_tests +from framework import tag_run_solo from vpp_neighbor import VppNeighbor from vpp_ip_route import find_route, VppIpTable from util import mk_ll_addr @@ -32,13 +33,10 @@ DHCP6_CLIENT_PORT = 547 DHCP6_SERVER_PORT = 546 +@tag_run_solo class TestDHCP(VppTestCase): """ DHCP Test Case """ - @classmethod - def force_solo(cls): - return True - @classmethod def setUpClass(cls): super(TestDHCP, cls).setUpClass() diff --git a/src/plugins/dhcp/test/test_dhcp6.py b/src/plugins/dhcp/test/test_dhcp6.py index ebd43729e4b..e35e0e1ccda 100644 --- a/src/plugins/dhcp/test/test_dhcp6.py +++ b/src/plugins/dhcp/test/test_dhcp6.py @@ -9,6 +9,7 @@ from scapy.layers.inet6 import IPv6, Ether, UDP from scapy.utils6 import in6_mactoifaceid from framework import VppTestCase +from framework import tag_run_solo from vpp_papi import VppEnum import util import os @@ -220,13 +221,10 @@ class TestDHCPv6DataPlane(VppTestCase): self.vapi.dhcp6_clients_enable_disable(enable=0) +@tag_run_solo class TestDHCPv6IANAControlPlane(VppTestCase): """ DHCPv6 IA NA Control Plane Test Case """ - @classmethod - def force_solo(cls): - return True - @classmethod def setUpClass(cls): super(TestDHCPv6IANAControlPlane, cls).setUpClass() diff --git a/src/plugins/flowprobe/test/test_flowprobe.py b/src/plugins/flowprobe/test/test_flowprobe.py index 4cf019ad47e..56724abe269 100644 --- a/src/plugins/flowprobe/test/test_flowprobe.py +++ b/src/plugins/flowprobe/test/test_flowprobe.py @@ -13,6 +13,7 @@ from scapy.layers.inet import IP, TCP, UDP from scapy.layers.inet6 import IPv6 from framework import VppTestCase, VppTestRunner, running_extended_tests +from framework import tag_run_solo from vpp_object import VppObject from vpp_pg_interface import CaptureTimeoutError from util import ppp @@ -343,13 +344,10 @@ class MethodHolder(VppTestCase): return p +@tag_run_solo class Flowprobe(MethodHolder): """Template verification, timer tests""" - @classmethod - def force_solo(cls): - return True - @classmethod def setUpClass(cls): super(Flowprobe, cls).setUpClass() diff --git a/src/plugins/memif/test/test_memif.py b/src/plugins/memif/test/test_memif.py index f2bbded320b..caaab87f1e8 100644 --- a/src/plugins/memif/test/test_memif.py +++ b/src/plugins/memif/test/test_memif.py @@ -5,6 +5,7 @@ from scapy.layers.l2 import Ether from scapy.layers.inet import IP, ICMP from framework import VppTestCase, VppTestRunner, running_extended_tests +from framework import tag_run_solo from remote_test import RemoteClass, RemoteVppTestCase from vpp_memif import remove_all_memif_vpp_config, \ VppSocketFilename, VppMemif @@ -12,13 +13,10 @@ from vpp_ip_route import VppIpRoute, VppRoutePath from vpp_papi import VppEnum +@tag_run_solo class TestMemif(VppTestCase): """ Memif Test Case """ - @classmethod - def force_solo(cls): - return True - @classmethod def setUpClass(cls): # fork new process before client connects to VPP diff --git a/src/vnet/bfd/test/test_bfd.py b/src/vnet/bfd/test/test_bfd.py index 784cdadb24d..71904a89f7f 100644 --- a/src/vnet/bfd/test/test_bfd.py +++ b/src/vnet/bfd/test/test_bfd.py @@ -22,6 +22,7 @@ from scapy.packet import Raw from bfd import VppBFDAuthKey, BFD, BFDAuthType, VppBFDUDPSession, \ BFDDiagCode, BFDState, BFD_vpp_echo from framework import VppTestCase, VppTestRunner, running_extended_tests +from framework import tag_run_solo from util import ppp from vpp_ip import DpoProto from vpp_ip_route import VppIpRoute, VppRoutePath @@ -677,6 +678,7 @@ def wait_for_bfd_packet(test, timeout=1, pcap_time_min=None, is_tunnel=False): return p +@tag_run_solo class BFD4TestCase(VppTestCase): """Bidirectional Forwarding Detection (BFD)""" @@ -685,10 +687,6 @@ class BFD4TestCase(VppTestCase): vpp_session = None test_session = None - @classmethod - def force_solo(cls): - return True - @classmethod def setUpClass(cls): super(BFD4TestCase, cls).setUpClass() @@ -1489,6 +1487,7 @@ class BFD4TestCase(VppTestCase): self.assertFalse(vpp_session.query_vpp_config()) +@tag_run_solo class BFD6TestCase(VppTestCase): """Bidirectional Forwarding Detection (BFD) (IPv6) """ @@ -1497,10 +1496,6 @@ class BFD6TestCase(VppTestCase): vpp_session = None test_session = None - @classmethod - def force_solo(cls): - return True - @classmethod def setUpClass(cls): super(BFD6TestCase, cls).setUpClass() @@ -1706,16 +1701,13 @@ class BFD6TestCase(VppTestCase): self.assertFalse(vpp_session.query_vpp_config()) +@tag_run_solo class BFDFIBTestCase(VppTestCase): """ BFD-FIB interactions (IPv6) """ vpp_session = None test_session = None - @classmethod - def force_solo(cls): - return True - @classmethod def setUpClass(cls): super(BFDFIBTestCase, cls).setUpClass() @@ -1896,6 +1888,7 @@ class BFDTunTestCase(VppTestCase): bfd_session_down(self) +@tag_run_solo class BFDSHA1TestCase(VppTestCase): """Bidirectional Forwarding Detection (BFD) (SHA1 auth) """ @@ -1904,10 +1897,6 @@ class BFDSHA1TestCase(VppTestCase): vpp_session = None test_session = None - @classmethod - def force_solo(cls): - return True - @classmethod def setUpClass(cls): super(BFDSHA1TestCase, cls).setUpClass() @@ -2131,6 +2120,7 @@ class BFDSHA1TestCase(VppTestCase): bfd_session_up(self) +@tag_run_solo class BFDAuthOnOffTestCase(VppTestCase): """Bidirectional Forwarding Detection (BFD) (changing auth) """ @@ -2138,10 +2128,6 @@ class BFDAuthOnOffTestCase(VppTestCase): vpp_session = None test_session = None - @classmethod - def force_solo(cls): - return True - @classmethod def setUpClass(cls): super(BFDAuthOnOffTestCase, cls).setUpClass() @@ -2347,14 +2333,11 @@ class BFDAuthOnOffTestCase(VppTestCase): "number of bfd events") +@tag_run_solo class BFDCLITestCase(VppTestCase): """Bidirectional Forwarding Detection (BFD) (CLI) """ pg0 = None - @classmethod - def force_solo(cls): - return True - @classmethod def setUpClass(cls): super(BFDCLITestCase, cls).setUpClass() -- cgit 1.2.3-korg