From 258aac905cd20f2a92ad2bd043770cf4ce4afc60 Mon Sep 17 00:00:00 2001 From: Benoît Ganne Date: Fri, 27 Jan 2023 11:37:59 +0100 Subject: af_xdp: fix netns configuration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - clib_open_netns() expects a NULL-terminated C-string - if no netns was given, we should not try to format it otherwise we'll get "(nil)" as netns name. Type: fix Change-Id: I7b6022f6e8999640d0d2a83b854455b15fa4c134 Signed-off-by: Benoît Ganne --- src/plugins/af_xdp/device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/plugins/af_xdp/device.c b/src/plugins/af_xdp/device.c index 06b86893646..570f34cdc7e 100644 --- a/src/plugins/af_xdp/device.c +++ b/src/plugins/af_xdp/device.c @@ -637,7 +637,8 @@ af_xdp_create_if (vlib_main_t * vm, af_xdp_create_if_args_t * args) ad->linux_ifname = (char *) format (0, "%s", args->linux_ifname); vec_validate (ad->linux_ifname, IFNAMSIZ - 1); /* libbpf expects ifname to be at least IFNAMSIZ */ - ad->netns = (char *) format (0, "%s", args->netns); + if (args->netns) + ad->netns = (char *) format (0, "%s%c", args->netns, 0); ad->linux_ifindex = if_nametoindex (ad->linux_ifname); if (!ad->linux_ifindex) -- cgit 1.2.3-korg