From 6e1eaad216c41ce1cb4af13a2214f4d86e094414 Mon Sep 17 00:00:00 2001 From: Andrew Yourtchenko Date: Thu, 15 Sep 2022 11:46:30 +0000 Subject: prom: fix coverity 277312, 277317 If one attempts to add a pattern with zero length, first time it will succeed, and the second time it will cause an invalid memcmp call. Solution: do not allow to add zero-length patterns. Type: fix Signed-off-by: Andrew Yourtchenko Change-Id: Ic08e021486153be605a4b12a2fe4422307bf68d2 --- src/plugins/prom/prom.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src') diff --git a/src/plugins/prom/prom.c b/src/plugins/prom/prom.c index 6db50204d65..3e0fa3b408d 100644 --- a/src/plugins/prom/prom.c +++ b/src/plugins/prom/prom.c @@ -305,6 +305,8 @@ prom_stat_patterns_add (u8 **patterns) { found = 0; len = vec_len (*pattern); + if (len == 0) + continue; vec_foreach (existing, pm->stats_patterns) { if (vec_len (*existing) != len) -- cgit 1.2.3-korg