From e4046528d412ff64bc1e0cfe3496a56119923718 Mon Sep 17 00:00:00 2001 From: Andrew Yourtchenko Date: Wed, 31 Aug 2022 14:20:40 +0000 Subject: pppoe: fix coverity 218437, 218401 Initialize the session index in case of error to ~0, so is defined in case trace needs to copy it. Type: fix Signed-off-by: Andrew Yourtchenko Change-Id: Iddf6df42c09d2abc11e5821944eb4f41692e6e3e --- src/plugins/pppoe/pppoe_decap.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src') diff --git a/src/plugins/pppoe/pppoe_decap.c b/src/plugins/pppoe/pppoe_decap.c index fe83c3a2c54..a1c37f6794f 100644 --- a/src/plugins/pppoe/pppoe_decap.c +++ b/src/plugins/pppoe/pppoe_decap.c @@ -154,6 +154,7 @@ VLIB_NODE_FN (pppoe_input_node) (vlib_main_t * vm, vlib_buffer_advance(b0, sizeof(*h0)+sizeof(*vlan0)); error0 = PPPOE_ERROR_CONTROL_PLANE; next0 = PPPOE_INPUT_NEXT_CP_INPUT; + result0.fields.session_index = ~0; goto trace0; } @@ -251,6 +252,7 @@ VLIB_NODE_FN (pppoe_input_node) (vlib_main_t * vm, vlib_buffer_advance(b1, sizeof(*h1)+sizeof(*vlan1)); error1 = PPPOE_ERROR_CONTROL_PLANE; next1 = PPPOE_INPUT_NEXT_CP_INPUT; + result1.fields.session_index = ~0; goto trace1; } @@ -378,6 +380,7 @@ VLIB_NODE_FN (pppoe_input_node) (vlib_main_t * vm, vlib_buffer_advance(b0, sizeof(*h0)+sizeof(*vlan0)); error0 = PPPOE_ERROR_CONTROL_PLANE; next0 = PPPOE_INPUT_NEXT_CP_INPUT; + result0.fields.session_index = ~0; goto trace00; } -- cgit 1.2.3-korg