From f5d9237c5699a6c3e403f09d53ec7d154322823c Mon Sep 17 00:00:00 2001 From: Dave Wallace Date: Thu, 27 May 2021 19:44:50 -0400 Subject: svm: fix inadequate atomic load for chunk mgr - Fixes intermittent LDP cut thru iperf3 test failure on AARCH64 Type: fix Change-Id: Id21a078d642e03d974bacacd1f4d0faa42fb6652 Signed-off-by: Dave Wallace (cherry picked from commit 5c520919e838bcb645ddd879641d54c620740989) --- src/svm/fifo_segment.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/svm/fifo_segment.c b/src/svm/fifo_segment.c index d8b3b259038..cb1f08a7e9f 100644 --- a/src/svm/fifo_segment.c +++ b/src/svm/fifo_segment.c @@ -154,7 +154,7 @@ fss_chunk_free_list_push (fifo_segment_header_t *fsh, csp = fs_chunk_sptr (fsh, c); ASSERT (csp <= FS_CL_HEAD_MASK); - old_head = clib_atomic_load_relax_n (&fss->free_chunks[fl_index]); + old_head = clib_atomic_load_acq_n (&fss->free_chunks[fl_index]); do { @@ -174,7 +174,7 @@ fss_chunk_free_list_push_list (fifo_segment_header_t *fsh, headsp = fs_chunk_sptr (fsh, head); ASSERT (headsp <= FS_CL_HEAD_MASK); - old_head = clib_atomic_load_relax_n (&fss->free_chunks[fl_index]); + old_head = clib_atomic_load_acq_n (&fss->free_chunks[fl_index]); do { @@ -194,7 +194,7 @@ fss_chunk_free_list_pop (fifo_segment_header_t *fsh, fifo_segment_slice_t *fss, ASSERT (fss_chunk_fl_index_is_valid (fss, fl_index)); - old_head = clib_atomic_load_relax_n (&fss->free_chunks[fl_index]); + old_head = clib_atomic_load_acq_n (&fss->free_chunks[fl_index]); /* Lock-free stacks are affected by ABA if a side allocates a chunk and * shortly thereafter frees it. To circumvent that, reuse the upper bits -- cgit 1.2.3-korg