From 9a6dafd569db0d0b5dc9d7b5b34b17e3f411a9ee Mon Sep 17 00:00:00 2001 From: Paul Vinciguerra Date: Wed, 6 Mar 2019 15:11:28 -0800 Subject: Tests: use self.assertNotIn(). Many tests use self.assertEqual(error.find("failed"), -1) Use self.assertNotIn("failed", error) to provide more meaningful errors such as AssertionError: 'Failed' not found in '' instead of 0 != -1. Change-Id: I670acdc977b788b2cedf94cfeafc12097781463f Signed-off-by: Paul Vinciguerra --- test/test_bier.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'test/test_bier.py') diff --git a/test/test_bier.py b/test/test_bier.py index 5a2c51c1708..9a9db3b0b6e 100644 --- a/test/test_bier.py +++ b/test/test_bier.py @@ -29,7 +29,7 @@ class TestBFIB(VppTestCase): if error: self.logger.critical(error) - self.assertEqual(error.find("Failed"), -1) + self.assertNotIn("Failed", error) class TestBier(VppTestCase): -- cgit 1.2.3-korg