From 073d74d0ba9a6110ed73a38df668c47ceb3ca776 Mon Sep 17 00:00:00 2001 From: Paul Vinciguerra Date: Mon, 27 Apr 2020 01:12:48 -0400 Subject: tap: implement sw_interface_tap_v2_dump filtering by sw_if_index Type: feature Change-Id: I6f607f383dc77a71e8712124f7613b38b4ac065a Signed-off-by: Paul Vinciguerra --- test/vpp_devices.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) (limited to 'test/vpp_devices.py') diff --git a/test/vpp_devices.py b/test/vpp_devices.py index 7e18eca65a9..9e272cafe32 100644 --- a/test/vpp_devices.py +++ b/test/vpp_devices.py @@ -14,16 +14,14 @@ class VppTAPInterface(VppInterface): self._mac_addr = mac_addr def get_vpp_dump(self): - dump = self._test.vapi.sw_interface_tap_v2_dump() - for entry in dump: - if entry.sw_if_index == self.sw_if_index: - return entry + dump = self._test.vapi.sw_interface_tap_v2_dump( + sw_if_index=self.sw_if_index) + return dump def add_vpp_config(self): - use_random_mac = True if self._mac_addr else False reply = self._test.vapi.tap_create_v2( id=self._tap_id, - use_random_mac=use_random_mac, + use_random_mac=bool(self._mac_addr), mac_address=self._mac_addr) self.set_sw_if_index(reply.sw_if_index) self._test.registry.register(self, self.test.logger) @@ -33,9 +31,7 @@ class VppTAPInterface(VppInterface): def query_vpp_config(self): dump = self.get_vpp_dump() - if dump: - return True - return False + return bool(dump) def object_id(self): return "tap-%s" % self._tap_id -- cgit 1.2.3-korg