From 4c7305f124cfa9c649ec6c9231eaf608fe336f1b Mon Sep 17 00:00:00 2001 From: Alexander Chernavin Date: Wed, 27 Dec 2023 12:37:16 +0000 Subject: flowprobe: fix flush callbacks when multiple workers IPFIX buffers are stored on a per worker thread basis. Currently, the flush callbacks will flush only buffers stored for the main thread. And buffers for worker threads will not be sent until their size reach the path MTU configured for the exporter. So if traffic is constant, the problem will unlikely to be visible. Buffers will be sent once they reach the maximum size. However, if traffic stops at some point and flush is triggered in order to make the plugin send all currently buffered data, this will not happen. And collectors will not receive that data. The plugin will keep the remaining data until traffic starts again, the buffers reach the maximum size, and be sent. With this fix, flush buffers for worker threads and for the main thread when the flush callbacks are triggered. This will allow to remove @tag_fixme_vpp_workers from the unit tests that don't set timers. The tests that set timers will still be failing for other multi-worker related problems. Type: fix Change-Id: I9a7d9cef8ddbec7ee68c79309e48e7bc0953d488 Signed-off-by: Alexander Chernavin --- test/test_flowprobe.py | 2 -- 1 file changed, 2 deletions(-) (limited to 'test') diff --git a/test/test_flowprobe.py b/test/test_flowprobe.py index 609099980fc..ac0433abc00 100644 --- a/test/test_flowprobe.py +++ b/test/test_flowprobe.py @@ -1228,7 +1228,6 @@ class DatapathTestsHolder(object): self.logger.info("FFP_TEST_FINISH_0002") -@tag_fixme_vpp_workers class DatapathTx(MethodHolder, DatapathTestsHolder): """Collect info on Ethernet, IP4 and IP6 datapath (TX) (no timers)""" @@ -1309,7 +1308,6 @@ class DatapathTx(MethodHolder, DatapathTestsHolder): ipfix.remove_vpp_config() -@tag_fixme_vpp_workers class DatapathRx(MethodHolder, DatapathTestsHolder): """Collect info on Ethernet, IP4 and IP6 datapath (RX) (no timers)""" -- cgit 1.2.3-korg