From b2a6e25067a41def7d5795df6d07231b55051ab2 Mon Sep 17 00:00:00 2001 From: Dave Barach Date: Wed, 27 Jul 2016 10:00:58 -0400 Subject: VPP-189 coverity warning cleanups Change-Id: Ia4fbf4352119504e022b89d10d44a5259d94f316 Signed-off-by: Dave Barach --- vlib-api/vlibapi/api_shared.c | 1 + vlib-api/vlibsocket/sockclnt_vlib.c | 1 + vlib-api/vlibsocket/socksvr_vlib.c | 1 + 3 files changed, 3 insertions(+) (limited to 'vlib-api') diff --git a/vlib-api/vlibapi/api_shared.c b/vlib-api/vlibapi/api_shared.c index 66f894b4edf..09502c692c3 100644 --- a/vlib-api/vlibapi/api_shared.c +++ b/vlib-api/vlibapi/api_shared.c @@ -774,6 +774,7 @@ vl_msg_api_process_file (vlib_main_t * vm, u8 * filename, if (fstat (fd, &statb) < 0) { vlib_cli_output (vm, "Couldn't stat %s\n", filename); + close (fd); return; } diff --git a/vlib-api/vlibsocket/sockclnt_vlib.c b/vlib-api/vlibsocket/sockclnt_vlib.c index 4ae274c228e..e8d749c58d4 100644 --- a/vlib-api/vlibsocket/sockclnt_vlib.c +++ b/vlib-api/vlibsocket/sockclnt_vlib.c @@ -107,6 +107,7 @@ sockclnt_open_index (char *client_name, char *hostname, int port) if (connect (sockfd, (const void *) &serv_addr, sizeof (serv_addr)) < 0) { clib_unix_warning ("Connect failure to (%s, %d)", hostname, port); + close(sockfd); return ~0; } diff --git a/vlib-api/vlibsocket/socksvr_vlib.c b/vlib-api/vlibsocket/socksvr_vlib.c index 91c6bfde674..eb8dd3340a1 100644 --- a/vlib-api/vlibsocket/socksvr_vlib.c +++ b/vlib-api/vlibsocket/socksvr_vlib.c @@ -602,6 +602,7 @@ socksvr_api_init (vlib_main_t * vm) if (bind (sockfd, (struct sockaddr *) &serv_addr, sizeof (serv_addr)) < 0) { + close (sockfd); return clib_error_return_unix (0, "bind"); } -- cgit 1.2.3-korg