diff options
| author |   Steven Luong <sluong@cisco.com> | 2019-08-14 19:12:17 -0700 |
|---|---|---|
| committer | Steven Luong <sluong@cisco.com> | 2019-08-14 19:21:16 -0700 |
| commit | 2961dfda406df702606b31b03dd30a1683f92e7c (patch) | |
| tree | c4f11ee2b2740998193cc4115a51431b611c442d | |
| parent | f92205ff63841c2ebfc4c6df731b43830125762d (diff) | |
devices: VPP crash when doing packet trace dump
VPP recycles the graph node index when the interface is deleted. Most tx graph
nodes have format_tx_function. tapcli does not. If tapcli happens to
recycle a tx graph node index which has format_tx_function, problem will arise
when showing the trace buffer which was collected for the node index that
tapcli recycles.
The fix is nothing fantasy, just add a format_tx_trace function which
does nothing in case it it called. tapcli is deprecated in 19.04. There is
no need to cherrypick this to later releases.
Type: fix
Ticket: VPP-1742
Signed-off-by: Steven Luong <sluong@cisco.com>
Change-Id: I010b3f35e59a474cb134a8b1bc718c242e3aa93c
| -rw-r--r-- | src/vnet/unix/tapcli.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/src/vnet/unix/tapcli.c b/src/vnet/unix/tapcli.c index b4df8e84fe4..81725a91a23 100644 --- a/src/vnet/unix/tapcli.c +++ b/src/vnet/unix/tapcli.c @@ -753,6 +753,13 @@ tapcli_interface_admin_up_down (vnet_main_t * vnm, u32 hw_if_index, u32 flags) return 0; } +u8 * +format_tapcli_tx_trace (u8 * s, va_list * va) +{ + s = format (s, "tapcli tx trace is not supported"); + return s; +} + /* *INDENT-OFF* */ VNET_DEVICE_CLASS (tapcli_dev_class,static) = { .name = "tapcli", @@ -761,6 +768,7 @@ VNET_DEVICE_CLASS (tapcli_dev_class,static) = { .rx_redirect_to_node = tapcli_set_interface_next_node, .name_renumber = tap_name_renumber, .admin_up_down_function = tapcli_interface_admin_up_down, + .format_tx_trace = format_tapcli_tx_trace, }; /* *INDENT-ON* */ |