diff options
| author |   Benoît Ganne <bganne@cisco.com> | 2021-04-29 18:24:24 +0200 |
|---|---|---|
| committer |   Damjan Marion <dmarion@me.com> | 2021-05-21 19:50:14 +0000 |
| commit | a42c41be4eed3e1ce2a42038b07ce1d3420891cd (patch) | |
| tree | fc95c7c24cbef993cc2bef8742b3360123d70b66 /src/plugins/af_xdp/cli.c | |
| parent | 92a8d761c412590f5112239be4c511091b2b2d5a (diff) | |
af_xdp: workaround kernel race between poll() and sendmsg()
Prior to Linux 5.6 there is a race condition between poll() and
sendmsg() in the kernel. This patch protects the syscalls with a lock
to prevent it, unless the NO_SYSCALL_LOCK flag is set at create time.
See
https://lore.kernel.org/bpf/BYAPR11MB365382C5DB1E5FCC53242609C1549@BYAPR11MB3653.namprd11.prod.outlook.com/
Type: fix
Change-Id: Ie7d4f5cb41f697b11a09b6046e54d190430d76df
Signed-off-by: Benoît Ganne <bganne@cisco.com>
Diffstat (limited to 'src/plugins/af_xdp/cli.c')
| -rw-r--r-- | src/plugins/af_xdp/cli.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/plugins/af_xdp/cli.c b/src/plugins/af_xdp/cli.c index d5f21d4c391..2f3deffaaee 100644 --- a/src/plugins/af_xdp/cli.c +++ b/src/plugins/af_xdp/cli.c @@ -47,7 +47,10 @@ af_xdp_create_command_fn (vlib_main_t * vm, unformat_input_t * input, /* *INDENT-OFF* */ VLIB_CLI_COMMAND (af_xdp_create_command, static) = { .path = "create interface af_xdp", - .short_help = "create interface af_xdp <host-if linux-ifname> [name ifname] [rx-queue-size size] [tx-queue-size size] [num-rx-queues <num|all>] [prog pathname] [zero-copy|no-zero-copy]", + .short_help = + "create interface af_xdp <host-if linux-ifname> [name ifname] " + "[rx-queue-size size] [tx-queue-size size] [num-rx-queues <num|all>] " + "[prog pathname] [zero-copy|no-zero-copy] [no-syscall-lock]", .function = af_xdp_create_command_fn, }; /* *INDENT-ON* */ |