1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
|
/* SPDX-License-Identifier: BSD-3-Clause
* Copyright(c) 2010-2014 Intel Corporation
*/
#include <stdio.h>
#include <string.h>
#include <inttypes.h>
#include <cmdline_parse.h>
#include <cmdline_parse_portlist.h>
#include "test_cmdline.h"
struct portlist_str {
const char * str;
uint32_t portmap;
};
/* valid strings */
const struct portlist_str portlist_valid_strs[] = {
{"0", 0x1U },
{"0-10", 0x7FFU},
{"10-20", 0x1FFC00U},
{"all", UINT32_MAX},
{"0,1,2,3", 0xFU},
{"0,1-5", 0x3FU},
{"0,0,0", 0x1U},
{"31,0-10,15", 0x800087FFU},
{"0000", 0x1U},
{"00,01,02,03", 0xFU},
{"000,001,002,003", 0xFU},
};
/* valid strings but with garbage at the end.
* these strings should still be valid because parser checks
* for end of token, which is either a space/tab, a newline/return,
* or a hash sign.
*/
const char * portlist_garbage_strs[] = {
"0-31 garbage",
"0-31#garbage",
"0-31\0garbage",
"0-31\ngarbage",
"0-31\rgarbage",
"0-31\tgarbage",
"0,1,2,3-31 garbage",
"0,1,2,3-31#garbage",
"0,1,2,3-31\0garbage",
"0,1,2,3-31\ngarbage",
"0,1,2,3-31\rgarbage",
"0,1,2,3-31\tgarbage",
"all garbage",
"all#garbage",
"all\0garbage",
"all\ngarbage",
"all\rgarbage",
"all\tgarbage",
};
/* invalid strings */
const char * portlist_invalid_strs[] = {
/* valid syntax, invalid chars */
"A-B",
"0-S",
"1,2,3,4,Q",
"A-4,3-15",
"0-31invalid",
/* valid chars, invalid syntax */
"1, 2",
"1- 4",
",2",
",2 ",
"-1, 4",
"5-1",
"2-",
/* misc */
"-"
"a",
"A",
",",
"#",
" ",
"\0",
"",
/* too long */
"0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,"
"0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,0,1,2",
};
#define PORTLIST_VALID_STRS_SIZE \
(sizeof(portlist_valid_strs) / sizeof(portlist_valid_strs[0]))
#define PORTLIST_GARBAGE_STRS_SIZE \
(sizeof(portlist_garbage_strs) / sizeof(portlist_garbage_strs[0]))
#define PORTLIST_INVALID_STRS_SIZE \
(sizeof(portlist_invalid_strs) / sizeof(portlist_invalid_strs[0]))
/* test invalid parameters */
int
test_parse_portlist_invalid_param(void)
{
cmdline_portlist_t result;
char buf[CMDLINE_TEST_BUFSIZE];
int ret;
memset(&buf, 0, sizeof(buf));
memset(&result, 0, sizeof(cmdline_portlist_t));
/* try all null */
ret = cmdline_parse_portlist(NULL, NULL, NULL, 0);
if (ret != -1) {
printf("Error: parser accepted null parameters!\n");
return -1;
}
/* try null buf */
ret = cmdline_parse_portlist(NULL, NULL, (void*)&result,
sizeof(result));
if (ret != -1) {
printf("Error: parser accepted null string!\n");
return -1;
}
/* try null result */
ret = cmdline_parse_portlist(NULL, portlist_valid_strs[0].str, NULL, 0);
if (ret == -1) {
printf("Error: parser rejected null result!\n");
return -1;
}
/* token is not used in ether_parse anyway so there's no point in
* testing it */
/* test help function */
/* coverage! */
ret = cmdline_get_help_portlist(NULL, buf, sizeof(buf));
if (ret < 0) {
printf("Error: help function failed with valid parameters!\n");
return -1;
}
return 0;
}
/* test valid parameters but invalid data */
int
test_parse_portlist_invalid_data(void)
{
int ret = 0;
unsigned i;
cmdline_portlist_t result;
/* test invalid strings */
for (i = 0; i < PORTLIST_INVALID_STRS_SIZE; i++) {
memset(&result, 0, sizeof(cmdline_portlist_t));
ret = cmdline_parse_portlist(NULL, portlist_invalid_strs[i],
(void*)&result, sizeof(result));
if (ret != -1) {
printf("Error: parsing %s succeeded!\n",
portlist_invalid_strs[i]);
return -1;
}
}
return 0;
}
/* test valid parameters and data */
int
test_parse_portlist_valid(void)
{
int ret = 0;
unsigned i;
cmdline_portlist_t result;
/* test full strings */
for (i = 0; i < PORTLIST_VALID_STRS_SIZE; i++) {
memset(&result, 0, sizeof(cmdline_portlist_t));
ret = cmdline_parse_portlist(NULL, portlist_valid_strs[i].str,
(void*)&result, sizeof(result));
if (ret < 0) {
printf("Error: parsing %s failed!\n",
portlist_valid_strs[i].str);
return -1;
}
if (result.map != portlist_valid_strs[i].portmap) {
printf("Error: parsing %s failed: map mismatch!\n",
portlist_valid_strs[i].str);
return -1;
}
}
/* test garbage strings */
for (i = 0; i < PORTLIST_GARBAGE_STRS_SIZE; i++) {
memset(&result, 0, sizeof(cmdline_portlist_t));
ret = cmdline_parse_portlist(NULL, portlist_garbage_strs[i],
(void*)&result, sizeof(result));
if (ret < 0) {
printf("Error: parsing %s failed!\n",
portlist_garbage_strs[i]);
return -1;
}
if (result.map != UINT32_MAX) {
printf("Error: parsing %s failed: map mismatch!\n",
portlist_garbage_strs[i]);
return -1;
}
}
return 0;
}
|
