summaryrefslogtreecommitdiffstats
path: root/adapter
diff options
context:
space:
mode:
authorOndrej Fabry <ofabry@cisco.com>2017-11-30 09:08:17 +0100
committerOndrej Fabry <ofabry@cisco.com>2017-11-30 09:08:17 +0100
commitacf57209ccbd67fa96644abe5aef65f58264c112 (patch)
tree59ed1cdcca28f21d4eee9451de031e41c500c710 /adapter
parent67482a4f8c3a3a7cf17b4edf82e61c28b318ffd9 (diff)
Removes unnecessary returned func from WaitReady
Change-Id: I34889c8c79fa8ef7a196f8d067edca7f1cb5ad33 Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Diffstat (limited to 'adapter')
-rw-r--r--adapter/adapter.go4
-rw-r--r--adapter/mock/mock_adapter.go4
-rw-r--r--adapter/vppapiclient/vppapiclient_adapter.go42
3 files changed, 24 insertions, 26 deletions
diff --git a/adapter/adapter.go b/adapter/adapter.go
index d8f29c9..a5b3352 100644
--- a/adapter/adapter.go
+++ b/adapter/adapter.go
@@ -31,6 +31,6 @@ type VppAdapter interface {
// SetMsgCallback sets a callback function that will be called by the adapter whenever a message comes from VPP.
SetMsgCallback(func(context uint32, msgId uint16, data []byte))
- // WaitReady returns func which waits until adapter is ready.
- WaitReady() func() error
+ // WaitReady waits until adapter is ready.
+ WaitReady() error
}
diff --git a/adapter/mock/mock_adapter.go b/adapter/mock/mock_adapter.go
index f85f17d..5407696 100644
--- a/adapter/mock/mock_adapter.go
+++ b/adapter/mock/mock_adapter.go
@@ -295,8 +295,8 @@ func (a *VppAdapter) SetMsgCallback(cb func(context uint32, msgID uint16, data [
}
// WaitReady mocks waiting for VPP
-func (a *VppAdapter) WaitReady() func() error {
- return func() error { return nil }
+func (a *VppAdapter) WaitReady() error {
+ return nil
}
// MockReply stores a message to be returned when the next request comes. It is a FIFO queue - multiple replies
diff --git a/adapter/vppapiclient/vppapiclient_adapter.go b/adapter/vppapiclient/vppapiclient_adapter.go
index dfdd973..1cdaf72 100644
--- a/adapter/vppapiclient/vppapiclient_adapter.go
+++ b/adapter/vppapiclient/vppapiclient_adapter.go
@@ -150,33 +150,31 @@ func (a *vppAPIClientAdapter) SetMsgCallback(cb func(context uint32, msgID uint1
a.callback = cb
}
-// WaitReady returns func which blocks until shared memory
-// for sending bin api calls is present on the file system.
-func (a *vppAPIClientAdapter) WaitReady() func() error {
- return func() error {
- watcher, err := fsnotify.NewWatcher()
- if err != nil {
- return err
- }
- defer watcher.Close()
+// WaitReady blocks until shared memory for sending
+// binary api calls is present on the file system.
+func (a *vppAPIClientAdapter) WaitReady() error {
+ watcher, err := fsnotify.NewWatcher()
+ if err != nil {
+ return err
+ }
+ defer watcher.Close()
- err = watcher.Add(watchedFolder)
- if err != nil {
- return err
- }
+ err = watcher.Add(watchedFolder)
+ if err != nil {
+ return err
+ }
- if fileExists(watchedFile) {
- return nil
- }
+ if fileExists(watchedFile) {
+ return nil
+ }
- for {
- ev := <-watcher.Events
- if ev.Name == watchedFile && (ev.Op&fsnotify.Create) == fsnotify.Create {
- break
- }
+ for {
+ ev := <-watcher.Events
+ if ev.Name == watchedFile && (ev.Op&fsnotify.Create) == fsnotify.Create {
+ break
}
- return nil
}
+ return nil
}
func fileExists(name string) bool {