diff options
author | mhalaj1 <matus.halaj@pantheon.tech> | 2021-08-26 20:15:08 +0200 |
---|---|---|
committer | mhalaj1 <matus.halaj@pantheon.tech> | 2021-09-07 15:24:53 +0200 |
commit | c09ee3241377aae2530a73d48c4e20641d76d0ee (patch) | |
tree | 219fd1f7d9ba595f0f4c8dac9796bc76ce3556fc /core/connection.go | |
parent | debc52dea8a81417bb08ca5bb934c7876b6d65e0 (diff) |
Refactoring and fixes
* refactor creation of new channel
* add missing closing of created streams
* correct documentation regarding thread safety of stream
Signed-off-by: mhalaj1 <matus.halaj@pantheon.tech>
Change-Id: Ic601efff298fcbdecaafab83fa236253af69de21
Diffstat (limited to 'core/connection.go')
-rw-r--r-- | core/connection.go | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/core/connection.go b/core/connection.go index ee5a06b..935693e 100644 --- a/core/connection.go +++ b/core/connection.go @@ -245,14 +245,7 @@ func (c *Connection) newAPIChannel(reqChanBufSize, replyChanBufSize int) (*Chann return nil, errors.New("nil connection passed in") } - // create new channel - chID := uint16(atomic.AddUint32(&c.maxChannelID, 1) & 0x7fff) - channel := newChannel(chID, c, c.codec, c, reqChanBufSize, replyChanBufSize) - - // store API channel within the client - c.channelsLock.Lock() - c.channels[chID] = channel - c.channelsLock.Unlock() + channel := c.newChannel(reqChanBufSize, replyChanBufSize) // start watching on the request channel go c.watchRequests(channel) |