summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2018-08-17HC2VPP-343: enable validation for acl listMarek Gradzki11-197/+338
This patch moves all validation for acl list to VppAclValidator, implementation of Validator interface brought by (HONEYCOMB-431): https://gerrit.fd.io/r/#/c/14022/ To test <validate> RPC, run ncclient tests with: ./edit_config.py acl/copy_config_unsupported-acl-type.xml -v Support for <validate> RPC requres: https://gerrit.fd.io/r/#/c/14040/ Change-Id: Iea591a76022e893f6aaf2a52637f45cadb284e4e Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-14HC2VPP-375: align classify session's match with skip-n-vectors zerosMarek Gradzki2-30/+24
If bigger values of skip-n-vectors are used (e.g. policer usecase), also key is very long, making the API hard to use. To make it easier, match value will be now aligned with zeros if needed. Read part does not need to be updated, beacause classify_session_dump returns match without skip-n-vectors part. Change-Id: Iab54480e7a3851690aed30c8f5b8b0e6769c054f Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-13Check length of classify session's match vector (HC2VPP-373)Marek Gradzki4-6/+70
Change-Id: I45028349f81a756d03d46e02af40041a7cae1fec Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-13Explicitly fail when classify table for given session is missingMarek Gradzki2-6/+18
Change-Id: Ied737af2eb650f54fbaa5413eb0a586793d34e43 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-13lisp: remove unnecessary Integer boxing in RemoteMappingCustomizerMarek Gradzki1-1/+1
Fixes issue reported by Sonar Change-Id: If7448ea2618cbcbad56c7dcf4c87ec6f1cc1cb39 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-13jvpp-benchmark: ignore unclosed resources reported by SonarMarek Gradzki2-0/+6
Sonar reports unclosed resources, but jvpp connections are closed in JVppBenchmark.tearDown. It is only a benchmark, so if JMH would crash and not call tearDown, then we don't really care. Change-Id: I60ae60c78610b8c07076c7d2a94917e8316d03dd Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-10Set mask/match length when using VPP's classfierMarek Gradzki5-1/+5
Adapts hc2vpp to recent VPP api change: https://gerrit.fd.io/r/#/c/13007/ Setting length field is currently mandatory for variable length arrays (VPP-199). Change-Id: I7ce66076d8a29d1ff5dfe5592e651d133e4072aa Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-08Fix prefixes in unicast-routing modelsMichal Cmarada2-2/+2
It is not valid to use different prefix for imports and augmentations. This fixes this issue and allows to use 2.0.6.1 yangtools version. Change-Id: Ie39228fc60a31028fbf74b964011539b7056d9f6 Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-07-27HC2VPP-341: remove v1.0/v2.0 postman collectionsMarek Gradzki22-11253/+2
Hc2vpp examples are using now v2.1 format. Change-Id: I945c03f8b80a4a74cf7064c566205ae5dc334d89 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-27Add script for bumping hc2vpp versionMarek Gradzki1-0/+23
The script simply replaces version string in all files from GIT index. TODO(HC2VPP-369): does not cover updating package versions and release notes. Change-Id: Iff4d84ced69873bd8d7e7d58714750d8f2b355e6 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-20Bump jvpp version to 18.10-SNAPSHOTMarek Gradzki15-23/+29
Also sets version of VPP package dependencies to 18.07. Change-Id: I4be0a5a9217c3e059125e7eb5a36170d02f12b88 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-20Release notes: update jira and project version to 18.10Marek Gradzki2-4/+4
Change-Id: I9180a1bd4f60846568381caf8f99548cbad3a0fc Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-20Bump hc2vpp version to 1.18.10-SNAPSHOTMarek Gradzki80-173/+173
Change-Id: I6ba9d0017cc42a4cafe3790e563e206d33c211b3 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-18Fix binding name for routeMichal Cmarada5-4/+91
In specific case when route uses 128 mask and this value is converted to byte value it is changed to -128, which breaks internal naming of routes. This needed to be fixed because routes with 128 mask are not being read from VPP to operational state. Change-Id: Ic3b6ded721e7996587982b6a2b3bc8c9ebe03b43 Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-07-17HC2VPP-176: add support for api-segment prefixMarek Gradzki2-7/+16
VPP can be run with custom SHM segment prefix: sudo vpp unix {cli-listen /run/vpp/cli-vpp1.sock} api-segment { prefix vpp1 } sudo vppctl -s /run/vpp/cli-vpp1.sock this patch adds optional api-segment-prefix parameter to /opt/honeycomb/config/jvpp.json file. Example configuration: { "jvpp-connection-name": "honeycomb", "api-segment-prefix": "vpp1", "jvpp-request-timeout": 5 } Change-Id: I7ca298644891602afe7898db88bb90d59b49ce4d Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-17Remove workaround for YANGTOOLS-678 from ietf-ipv6-unicast-routing modelMarek Gradzki1-15/+0
YANGTOOLS-678 was fixed in Oxygen SR2 used in HC since 18.07. Change-Id: I7a68e8f7178a7448216825ae64d968552686bba3 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-17Remove workarounds from ietf-routing-types related to MDSAL-269Marek Gradzki12-37/+97
Change-Id: Iadd17a3a44a20711e58c272934fb15dfe89bf2be Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-17Remove workarounds from ietf-routing-types related to MDSAL-309Marek Gradzki1-10/+2
MDSAL-309 was fixed in Oxygen SR1 used in HC since 18.07. Change-Id: I65f4574a10afa7ee1875446d7bfcb04aeca8674b Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-17Remove workarounds from routing and mpls models related to YANGTOOLS-841Marek Gradzki4-20/+11
YANGTOOLS-841 was fixed in Oxygen SR1 used by HC since 18.07. Change-Id: Ifa2627e284574a0bab84763dc2b6252a4b6be4a3 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-04HC2VPP-79: use AddressTranslator for ip-address-no-zone translationMarek Gradzki10-104/+66
Change-Id: I46955630709e3d837f95f488cb2fe089952865c4 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-04HC2VPP-275: use ip-address-no-zone in v3po YANG modelMarek Gradzki15-95/+95
The inet:ip-address type was used in HC models due to ODL bug: https://bugs.opendaylight.org/show_bug.cgi?id=6413 which was fixed long time ago... Change-Id: Icaa8ac1269c730243afba53bc663f39f7c90f36c Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-04HC2VPP-367: update ietf-nat model from 2018-02-23 to 2018-06-28Marek Gradzki26-168/+150
The 2018-06-28 revision: - removes mandatory statement for limit-per-subscriber (previously commented out due to HC2VPP-328), - removes logging-enable leaf that was not supported by hc2vpp Change-Id: I36c2b05029331db03e37c016a31b32d6abf4ac06 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-03HC2VPP-79: provide AddressTranslator.ipAddressToArray for IpAddressNoZoneMarek Gradzki4-0/+43
Change-Id: I637842ea6a582676ab305c29b5d8464987537be0 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-03HC2VPP-79: use ip-address-no-zone for proxy-arp configurationMarek Gradzki6-22/+21
The inet:ipv4-address type was used in HC models due to ODL bug: https://bugs.opendaylight.org/show_bug.cgi?id=6413 which was fixed long time ago... Change-Id: Ibb57c9b725a038784808e61c1e709663b9c9b9e6 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-03Bump v3po model versions from 2017-06-07 to 2018-07-03Marek Gradzki74-393/+401
Change-Id: I7ed600c929b130edf84c09d136e95e32cab4be9e Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-03HC2VPP-346: use fib-table-list-ref for FIB to ifc assignmentMarek Gradzki7-26/+35
Change-Id: Ie57776ab9784b7c57630b7ea9ce9b96b71feb5a5 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-02Fix VXLAN state readMarek Gradzki2-16/+31
Use UnsignedInts.toLong instead of (long) cast. Change-Id: I1b6875860019f3449bc32f16cd959f3084583d20 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-02HC2VPP-346: use fib-table-list-ref for VXLAN configurationMarek Gradzki5-8/+20
User is required to explicitly configure FIB tables using vpp-fib-management module. The change does not require modification of RESTCONF and NETCONF requests. Change-Id: Ie3cbff61281ba1a7a9e14c0a26cbd9ce6e44587f Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-02HC2VPP-348: use vpp-fib-management module instead of FIB table indexMarek Gradzki13-102/+91
Change-Id: Iba1f6d4c556c8ef839eb309b990f32945e6494fb Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-02HC2VPP-349: use fib-table-list-ref in the proxy-arp modelMarek Gradzki8-22/+78
User is now required to explicitly configure FIB tables using vpp-fib-management module. The patch also adds non-default vrf configuration example to the proxy-arp postman collection. Change-Id: I8cbdf0add8992bfb0a6a8fe0a38d6a466d5951f0 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-02Add initializer for FIB tablesMarek Gradzki3-7/+22
Default FIB tables (ID=0) are created in VPP during startup for both ipv4 and ipv6. In order to prevent oper and cfg mismatch, HC needs to update its cfg during startup. This patch adds initializer for FIB tables which handles that task. Change-Id: Iadae8d545985a07fdb32000d3ca498cf3f9b40ed Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-02Move Proxy Arp RESTCONF examples to separate POSTMAN collectionMarek Gradzki2-240/+243
Proxy Arp implementation is part of l3 plugin, so move configuration examples there as well. Change-Id: If3eb22dd295901529035e1ea231e9133d6e86bc7 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-29jvpp-benchmark: improve exception handlingMarek Gradzki3-9/+6
Fixes several issues found by Sonar. Change-Id: I7ab017f9d89221e8eff4b2438b7669df608b5587 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-28fix Cast one of the operands to a long bugMichal Cmarada1-2/+2
both of operands are int type which can cause loss of data. This changes the types of operands to long Change-Id: Ie162d52b1f853c0d83d51c8871af42a597b93386 Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-06-28srv6: simplify if condition in SidCustomizer.extractLocPrefixMarek Gradzki1-2/+1
Do not check loc.getPrefix() == null twice. Change-Id: I04a9dae25e14761d7f287aedd636dda8169f2dc9 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-28srv6: do not check if SidCustomizer.bindRequest() returns nullMarek Gradzki1-9/+0
Such comparison is allways false. Change-Id: I39d4caac4146d48c04ecf28b3c9ecf7ae0127949 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27bgp: mark parameters of hc2vpp RouteWriters as @NonNullMarek Gradzki3-16/+13
Requires https://gerrit.fd.io/r/#/c/13254/ Change-Id: Icacf161f1c47f9471f19b0d89e5f2396942537ec Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27BD: remove redundant null check in BridgeDomainCustomizerMarek Gradzki1-10/+8
Details objects cannot be null. Change-Id: I2a1c0991ec2ccfee4c6d35c77321c6cb67f4bb7f Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27lisp: fix sonar issues in SubtableDumpParamsMarek Gradzki1-5/+4
Change-Id: Ic53723df24e8c373fab3f2a63d21de39c1fac156 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27examples/ncclient: fix repo linkMarek Gradzki1-1/+1
Change-Id: If9b2f1d8fd22b7e9df3069dd65e7db2900027a92 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27examples/ncclient: use ncclient repo instead of forkMarek Gradzki1-1/+1
There is no need for using fork after support for <config> was merged: https://github.com/ncclient/ncclient/pull/232 Change-Id: I0bd4a1ce6c4263228771ae3a74e298640a0c2a40 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-22HC2VPP-317: remove FibTableServiceMichal Cmarada5-326/+0
After implementing FIB table management in SRv6 and routing FibTableService is no longer necessary and can be removed. Change-Id: I797ac52d5ed8ee1c6bf901895080aa06e5ac9016 Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-06-22hide Srv6Util constructor in SRv6 moduleMichal Cmarada1-0/+3
Hide default constructor to prevent creating instance of Srv6Util class. Change-Id: I805ce1971883426d8df3d9ce6eac2e5bd6ce201a Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-06-22HC2VPP-344: Add FIB table management for routingMichal Cmarada20-468/+555
- update models with FIB table management - fixes implementation for FIB table management Change-Id: I5cf397d6e827cb14df970e14ee268ef870931bd4 Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-06-22HC2VPP-88: translation layer for af_packet interface managementMarek Gradzki10-102/+736
Includes postman collection with RESTCONF examples. Change-Id: If6f7ba1e2e7ab37433ebc5215e4731f1193c62a2 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-21HC2VPP-88: yang model for af_packet interface managementMarek Gradzki1-0/+31
Change-Id: Iaa21ad832d03f36d7d8a6f63a68a6a7ece7c9b8d Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-21Fix NPE in InterfaceDataTranslator.isInterfaceOfTypeMarek Gradzki2-6/+55
SwInterfaceDetails returned by dump manager are nullable. In that case isInterfaceOfType should return false. Change-Id: Iaf3d1f6c6923ed6863357fe2470716f135b6164f Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-20Add SRv6 5 node docker demoMichal Cmarada16-15/+1089
This demo is intended to test SRv6 implementation. There are two options how to run the demo. First one is to use VPP only configuration and the second one uses honeycomb to configure SRv6 on nodes. For detailed information about the demo read documentation in ./asciidoc/Readme.adoc file. Follow the instructions to run the demo and use provided commands to verify the operation of VPP nodes. Change-Id: I7d17db0096cc48b06e9148e7c78faaf9d7b8a97d Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-06-19HC2VPP-304 - add SRv6 policy moduleMichal Cmarada56-10/+6395
new models: - hc2vpp-oc-srte-policy@2017-09-18.yang (ietf draft for srte-policies) - vpp-oc-srte-policy@2018-05-14.yang (augments oc-srte-policy model with VPP specific configuration) - policy-context@2018-06-07.yang defines policy contexts for policies and candidate paths new features: - adds support for writing/reading SRv6 policies - adds support for writing/reading L2 steering - adds support for writing/reading L3 steering - implements support for FIB table management (HC2VPP-345) Change-Id: Ie83ac8ecdcc0e46086e1ecdaecbb811746151c2f Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-06-19HC2VPP-288 - add readers for SRv6 moduleMichal Cmarada39-100/+2101
Changes: - add locator context to map locator name to locator IPv6Prefix - add readers for SRv6 module - implements reading of local sids and their end functions. - implements support for FIB table management (HC2VPP-345) Change-Id: Ib04402539a0b6666c5a1d0b4e1b5b5e08ccbf67b Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>