diff options
author | Marek Gradzki <mgradzki@cisco.com> | 2016-09-05 09:44:34 +0200 |
---|---|---|
committer | Marek Gradzki <mgradzki@cisco.com> | 2016-09-05 09:44:36 +0200 |
commit | 2645ef7b9214bff46fcfc8933fed9d571bc6abe5 (patch) | |
tree | a16ca3bdcd0ea38311141467f16faf32700bf030 | |
parent | e562a8f1e0796a9699fc93e5b18de2c386b730f8 (diff) |
Fix Writer Factory: remove AutoClosable from list
of implemented interfaces.
WriterFactories do not need to be AutoClosable.
Change-Id: I1947489b7eac2ccf4c34b3212c93ed76922a595f
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
4 files changed, 4 insertions, 8 deletions
diff --git a/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/WriterFactory.java b/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/WriterFactory.java index 70328c7f5..cec88336f 100644 --- a/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/WriterFactory.java +++ b/infra/translate-api/src/main/java/io/fd/honeycomb/translate/write/WriterFactory.java @@ -24,15 +24,11 @@ import javax.annotation.Nonnull; * Factory producing writers for {@link ModifiableWriterRegistryBuilder}. */ @Beta -public interface WriterFactory extends AutoCloseable { +public interface WriterFactory { /** * Initialize 1 or more writers and add them to provided registry. */ void init(@Nonnull ModifiableWriterRegistryBuilder registry); - @Override - default void close() { - // NOOP TODO allow unregister - } } diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/InterfacesWriterFactory.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/InterfacesWriterFactory.java index 3c5d341ba..6ffe3c30c 100644 --- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/InterfacesWriterFactory.java +++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/InterfacesWriterFactory.java @@ -71,7 +71,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.openvpp.jvpp.core.future.FutureJVppCore; -public final class InterfacesWriterFactory implements WriterFactory, AutoCloseable { +public final class InterfacesWriterFactory implements WriterFactory { public static final InstanceIdentifier<Interface> IFC_ID = InstanceIdentifier.create(Interfaces.class).child(Interface.class); diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/VppClassifierHoneycombWriterFactory.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/VppClassifierHoneycombWriterFactory.java index 829e8728c..6c52811fa 100644 --- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/VppClassifierHoneycombWriterFactory.java +++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/VppClassifierHoneycombWriterFactory.java @@ -33,7 +33,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.vpp.clas import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.openvpp.jvpp.core.future.FutureJVppCore; -public final class VppClassifierHoneycombWriterFactory implements WriterFactory, AutoCloseable { +public final class VppClassifierHoneycombWriterFactory implements WriterFactory { public static final InstanceIdentifier<ClassifyTable> CLASSIFY_TABLE_ID = InstanceIdentifier.create(VppClassifier.class).child(ClassifyTable.class); diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/VppHoneycombWriterFactory.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/VppHoneycombWriterFactory.java index cb2143865..3f3a90d3d 100644 --- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/VppHoneycombWriterFactory.java +++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/VppHoneycombWriterFactory.java @@ -38,7 +38,7 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.v3po.rev import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.openvpp.jvpp.core.future.FutureJVppCore; -public final class VppHoneycombWriterFactory implements WriterFactory, AutoCloseable { +public final class VppHoneycombWriterFactory implements WriterFactory { private final FutureJVppCore jvpp; private final NamingContext bdContext; |