diff options
author | 2017-11-20 13:14:17 +0100 | |
---|---|---|
committer | 2017-11-20 13:25:55 +0100 | |
commit | f491b8b15cb634eac60378b0504a715c0ad8ccda (patch) | |
tree | 8c6445f290d2e0a6b58062f1a14ba43dd8e72e78 /infra/bgp-distribution-test/src | |
parent | 0f92e8f1eb7ec29f589ed92c55b049f13cce0f30 (diff) |
Use InetAddresses.forString instead of InetAddress.getByName
Unlike InetAddress.getByName(), Guava's InetAddresses.forString()
never cause DNS services to be accessed.
JDK equivalents whenever you are expecting to handle only IP address string literals,
so there is no blocking DNS penalty for a malformed string.
See:
https://google.github.io/guava/releases/22.0/api/docs/com/google/common/net/InetAddresses.html#forString-java.lang.String-
Change-Id: Id1fc5fa45465b0e0b3aea7d60b9fdb855240d902
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Diffstat (limited to 'infra/bgp-distribution-test/src')
-rw-r--r-- | infra/bgp-distribution-test/src/test/java/io/fd/honeycomb/infra/bgp/distro/BgpDistributionTest.java | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/infra/bgp-distribution-test/src/test/java/io/fd/honeycomb/infra/bgp/distro/BgpDistributionTest.java b/infra/bgp-distribution-test/src/test/java/io/fd/honeycomb/infra/bgp/distro/BgpDistributionTest.java index 93dddf113..d2dc51af5 100644 --- a/infra/bgp-distribution-test/src/test/java/io/fd/honeycomb/infra/bgp/distro/BgpDistributionTest.java +++ b/infra/bgp-distribution-test/src/test/java/io/fd/honeycomb/infra/bgp/distro/BgpDistributionTest.java @@ -20,6 +20,7 @@ import static org.junit.Assert.assertTrue; import com.google.common.base.Charsets; import com.google.common.io.ByteStreams; +import com.google.common.net.InetAddresses; import com.mashape.unirest.http.HttpResponse; import com.mashape.unirest.http.Unirest; import com.mashape.unirest.http.exceptions.UnirestException; @@ -108,8 +109,8 @@ public class BgpDistributionTest { } private void assertBgpOpenIsSent(final String peerAddress) throws IOException, InterruptedException { - final InetAddress bgpHost = InetAddress.getByName(BGP_HOST_ADDRESS); - final InetAddress bgpPeerAddress = InetAddress.getByName(peerAddress); + final InetAddress bgpHost = InetAddresses.forString(BGP_HOST_ADDRESS); + final InetAddress bgpPeerAddress = InetAddresses.forString(peerAddress); try (final Socket localhost = new Socket(bgpHost, BGP_PORT, bgpPeerAddress, 0); final InputStream inputStream = localhost.getInputStream()) { // Wait until bgp message is sent |