diff options
| author |   Marek Gradzki <mgradzki@cisco.com> | 2016-05-09 10:13:24 +0200 |
|---|---|---|
| committer | Marek Gradzki <mgradzki@cisco.com> | 2016-05-09 12:44:43 +0200 |
| commit | 6627d1ff52b6df780bac4a6f56a3f4587ee4847b (patch) | |
| tree | 6dee5f3d2580243cd7584099e4c521a69689a65b /v3po/translate-impl/src/main/java/io | |
| parent | 4dcba2bceea09e6da71d6191df06d7d0201e699b (diff) | |
Comment out equality check in AbstractCompositeWriter.updateCurrent
There is a bug in ODL when checking auguments for equality:
https://git.opendaylight.org/gerrit/#/c/37719
Until the bug is fixed, updateCurrentAttributes will be invoked
even if there was no data change. It is customizer responsibility
to perform equality check if invoking update without actual data
change can cause side-effects in VPP.
Change-Id: Id72ec55ea7179330a4ebb1df49c29195908c5461
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Diffstat (limited to 'v3po/translate-impl/src/main/java/io')
| -rw-r--r-- | v3po/translate-impl/src/main/java/io/fd/honeycomb/v3po/translate/impl/write/AbstractCompositeWriter.java | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/v3po/translate-impl/src/main/java/io/fd/honeycomb/v3po/translate/impl/write/AbstractCompositeWriter.java b/v3po/translate-impl/src/main/java/io/fd/honeycomb/v3po/translate/impl/write/AbstractCompositeWriter.java index b71200fc9..580910e8c 100644 --- a/v3po/translate-impl/src/main/java/io/fd/honeycomb/v3po/translate/impl/write/AbstractCompositeWriter.java +++ b/v3po/translate-impl/src/main/java/io/fd/honeycomb/v3po/translate/impl/write/AbstractCompositeWriter.java @@ -98,12 +98,14 @@ public abstract class AbstractCompositeWriter<D extends DataObject> implements W final WriteContext ctx) throws WriteFailedException { LOG.debug("{}: Updating current: {} dataBefore: {}, datAfter: {}", this, id, dataBefore, dataAfter); - /* FIXME: Equals does not work properly with augments: https://git.opendaylight.org/gerrit/#/c/37719 */ - if (dataBefore.equals(dataAfter)) { - LOG.debug("{}: Skipping current(no update): {}", this, id); - // No change, ignore - return; - } + // FIXME: Equals does not work properly with augments: https://git.opendaylight.org/gerrit/#/c/37719 + // Solution: update mdsal-binding-dom-codec to 0.8.2-Beryllium-SR2 when it will be published in + // ODL release repository + //if (dataBefore.equals(dataAfter)) { + // LOG.debug("{}: Skipping current(no update): {}", this, id); + // // No change, ignore + // return; + //} switch (traversalType) { case PREORDER: { |