diff options
| author |   Jan Srnicek <jsrnicek@cisco.com> | 2016-09-12 13:12:14 +0200 |
|---|---|---|
| committer |   Maros Marsalek <mmarsale@cisco.com> | 2016-09-12 15:32:47 +0000 |
| commit | e3b80306cd697465aa51f42d14ca77d391a0a0ee (patch) | |
| tree | 4ca5f964fe89e13186e2b93ccd9d2c9d1b879b8a /v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/ip/Ipv4WriteUtils.java | |
| parent | fe9301f5b92c7f6aadf7649ce64765e78e5a78cf (diff) | |
HONEYCOMB-142 - Subnet validation
Added validation of address to not be from same
subnet
Refactored to detect conflicts with mixed types of subnets and report them better
Change-Id: Ib815a79c9f61e88b5097884e346320028bbfe914
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Diffstat (limited to 'v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/ip/Ipv4WriteUtils.java')
| -rw-r--r-- | v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/ip/Ipv4WriteUtils.java | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/ip/Ipv4WriteUtils.java b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/ip/Ipv4WriteUtils.java index f981d0db0..412030200 100644 --- a/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/ip/Ipv4WriteUtils.java +++ b/v3po/v3po2vpp/src/main/java/io/fd/honeycomb/translate/v3po/interfaces/ip/Ipv4WriteUtils.java @@ -34,8 +34,8 @@ import org.openvpp.jvpp.core.future.FutureJVppCore; /** * Utility class providing Ipv4 CUD support. */ -// TODO replace with interface with default methods or abstract class -final class Ipv4WriteUtils { +// TODO HONEYCOMB-175 replace with interface with default methods or abstract class +public final class Ipv4WriteUtils { private static final int DOTTED_QUAD_MASK_LENGTH = 4; private static final int IPV4_ADDRESS_PART_BITS_COUNT = 8; @@ -83,7 +83,7 @@ final class Ipv4WriteUtils { * @param mask the subnet mask in dot notation 255.255.255.255 * @return the prefix length as number of bits */ - static byte getSubnetMaskLength(final String mask) { + public static byte getSubnetMaskLength(final String mask) { String[] maskParts = mask.split("\\."); checkArgument(maskParts.length == DOTTED_QUAD_MASK_LENGTH, |