Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: Idc574442618d5ace087015c842fe2b8f72fb0ae2
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: I5b684eed325af39b465033c41c4b0334e97398eb
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: Ibc689d346358ecacf9a401d98c17673302294c76
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: Id5f6eb84ade0514bd9f1579e34c395994eeef4b2
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: I3c1ce39838c0166a31203461313152bb9d819460
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: I150ab8b52d1920da38909310df372711dcc67f4c
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: Ib8e820256daebd7d9bfc7f4a8610e72abe42bbb5
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: Ibdcd506919a7c6de600907e564399ff8aea707ae
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: Id5dff0164ef8b17de5aeebc7de2297c5a568725c
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
- updated dependencies
- compilation error fixes
Change-Id: Iad9d353d06c113a0da892ff11a442e4b41edae0d
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: I5e53b8404a437bf0d08eefcfc417e5d6d46fa0b4
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
- bumps ODL dependencies to neon
- migrates guava optional to java.utils.optional
Change-Id: Ibdaa365c7e21a341103aba88dfd67277e40d2969
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: I944977e931b4826f055d65b841898e9aa549b971
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: Iaab95d1a821673f9138ba8a118c2e265826a6288
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: I6e0820df7bc654f7847c517930c98599624dd288
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: Ic3e48d39d570632743c66b9317cd638fba84a34f
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
This patch introduces ValidableTransaction interface,
used by Honeycomb's DataBroker to implement
Netconf's DOMDataTransactionValidator.
WriteTransaction implements ValidableTransaction
by delegating validate to DataModification
for both config and operational modifications.
This patch requires ODL Fluorine (HONEYCOMB-433),
which brings support for <candidate> validation to Netconf.
Alternatively custom ODL Oxygen build
with patches from stable/oxygen/oxygen-hc-improvements.
Change-Id: Ic3eaffaef0314d22da3ea37f9416f18ccb0b99ae
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: I142ebd2899272feff00abe7d4bae708f093ee3ec
Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
|
|
Add INFO.yaml to list:
- Project description
- Properties
- Issue Tracking
- Contacts
- PTL information
- Meeting information
- Committer information
Change-Id: Ibe3fae589600784d98880e017e54c66a34d0c2e3
Signed-off-by: Vanessa Rene Valderrama <vvalderrama@linuxfoundation.org>
|
|
Change-Id: Ia64b0869d1f2d9620d233f31077e72d887ef4716
Signed-off-by: Marek Gradzki <margradz@gmail.com>
|
|
Some of the writers do not support update,
also write/delete might not require validation.
Therefore, in order to reduce amount of boilerplate code,
make validateXXX methods default with empty implementation.
Change-Id: Id205b478900024c59834a6e6cb18bdbeb9b43792
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Sonar reports FIXMES as issues with higher priority as TODOs.
FIXMEs should only be used for known bugs,
not for improvements.
Also include JIRA issue ID in the TODO message.
Change-Id: I47461d948421ff17532f17ecec3ddae84239511f
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I2ab95afb733885b3034dfc6a8cbad795fbf5ba6c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Use xxxCurrentAttributes instead to simplify call graph.
Change-Id: I8201b115354dddd35ca0b63b2c72dfb4eac93646
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
This patch introduces FlatWriterRegistry.validateModifications.
Implementation iterates over writersOrder following bulkUpdate logic
to properly support subtree writers case.
Writers are now cabable of validating modifications.
Commonly used implementations (GenericWriter and GenericListWriter)
delegate validation capbility to Validators.
Change-Id: If7a0bb0838c0b8f2c0393c989f3b03853a2ea679
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
This patch introduces ModifiableDataTreeDelegator.validateCandidate
that translates DataTreeCandidate to DataObjectUpdates
and delegates validation to WriterRegistry (similarly as for bulk update).
ModifiableDataTreeManager.commit implementation
invokes validation before bulk update.
To make it efficient, DataObjectUpdates are computed once
and stored in DataTreeContext.
Change-Id: If4bd558e64ed84c11c9c50c7a98a2aaa8db841bb
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
This patch modifies contract of DataModification.validate
to make it idempotent.
ModifiableDataTreeManager.validate now invokes dataTree.validate
on a copy of DataTreeModification.
ModifiableDataTreeManager.validateCandidate was introduced
to allow additional validation.
Change-Id: I86fc101faff9b04afde2f3eb16fff4d4df2867ad
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Fixes issue reported by Sonar.
Change-Id: Ibf9bc89ee09f151a56766213714829abdb7012bb
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Utility classes should not be instantiated.
Change-Id: Iff821556ad6b593bce6b3e056241dc7e2bbe0c8b
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: Ic490d8b850fcd270ff49e1c682f40c0324afe3d6
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
this was used a while ago when we were using ODL dependencies with
config subsystem. Once ODL moved to Blueprint this become obsolete.
Several classes used in this provider are marked deprecated and are
removed in ODL Fluorine.
Change-Id: I5bd415a271a9d53ad40f785bdc3840c410f79249
Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
|
|
Change-Id: Ib178651a07b55f7e732a45751c31b678296b2083
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
The test does not use <validate> RPC
in contrast to ValidateTest from:
https://gerrit.fd.io/r/#/c/14040/
Change-Id: I57da44256515cf10afbd86ef7d7b1607caa3f52e
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I2bed263c71b38e28706cb869232482b951158fd1
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Fixes issue reported by Sonar.
Change-Id: I083eb089f1ccd691a2015eaa401fe5acf7c59d49
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: Ie17b819efd381983754065a821771eb3aac11d06
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I5944e9fd9388fbc533bf909b171b0672d798ad82
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I4efbdcc4bc12e29bd767c7b8fa6696de62ac1d37
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I02b4f5948ae8818412d1ae0f7b3e1ac4acd55726
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: Ibd371b845debac895fad97b4e15732d858e00a3c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I25a22a194048637ea72dd35767e1e1701b5723e4
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
DataContainerNode is DataContainerChild.
Change-Id: I9122f9f3c27951f2d498f714d2ea15ebc96abdf3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
The RouteWriter interface is used by LocRibChangeListener, which
never passes null parameters.
Change-Id: I33a775de6c67d24bc271c0af21c9634c661e85e9
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: Ied63ccd3fbc7e645ba3fa2db16528b3209319fa7
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I76cc110ac7e0a64cdad79a7614f9e8b5eb624428
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I17dba7ad77f4d7865f887056062d0748ca699d44
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
DataTreeModification.ready() used by DataModification.validate()
might throw IllegalArgumentException in case of missing mandatory nodes.
Use broader Exception type in WriteTransaction.submit()
to make sure contract defined by AsyncWriteTransaction is preserved.
Change-Id: I95cb3e1e8c6db36df90d2c78e7d63c854189e2fd
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I37c247279c37c3fb066186c8390e827a9611b99e
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: Ibf01bcaf65bb048fcfae57b5ba0597faff5e4fe6
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Also fixes Sonar warning regarding
useless CapabilityChangeNotificationProducer instantiation.
Change-Id: I376b834618d34f13615051abf622e6b12e031050
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|