summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2019-02-04Honeycomb 1.19.01 release notesMichal Cmarada1-0/+2
Change-Id: Ia5aa09af8aa45ce8cd27abed6eb86099b8620ee4 Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
2019-01-24Set Honeycomb version back to 1.19.01-SNAPSHOTMichal Cmarada75-147/+147
Change-Id: I61377b9f62a919983d5d51614ad3130c6c0e016c Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
2019-01-24Honeycomb 1.19.01-RC1v1.19.01-RC1Michal Cmarada75-147/+147
Change-Id: Ide7d955084f224e63d644a0e11299e01d3c7e9b5 Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
2019-01-23Release notes: set <project-branch> to stable/1901Michal Cmarada1-1/+1
Change-Id: Ia85b5fd1352374ff6f9d73dd04a2544db1f576c6 Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
2019-01-23Set stable/1901 as default branch for gitreviewMichal Cmarada1-0/+1
Change-Id: I65c77258bbc4bae45eaa864705a240a219832f05 Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
2018-10-19Release notes: update jira project version for 1.19.01Michal Cmarada2-3/+3
Change-Id: I6e0820df7bc654f7847c517930c98599624dd288 Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
2018-10-19Bump honeycomb version to 1.19.01-SNAPSHOTMichal Cmarada75-147/+147
Change-Id: Ic3e48d39d570632743c66b9317cd638fba84a34f Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
2018-10-08HONEYCOMB-431: add support for <validate> RPCMichal Cmarada15-22/+470
This patch introduces ValidableTransaction interface, used by Honeycomb's DataBroker to implement Netconf's DOMDataTransactionValidator. WriteTransaction implements ValidableTransaction by delegating validate to DataModification for both config and operational modifications. This patch requires ODL Fluorine (HONEYCOMB-433), which brings support for <candidate> validation to Netconf. Alternatively custom ODL Oxygen build with patches from stable/oxygen/oxygen-hc-improvements. Change-Id: Ic3eaffaef0314d22da3ea37f9416f18ccb0b99ae Signed-off-by: Marek Gradzki <mgradzki@cisco.com> Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
2018-09-25Bump ODL dependencies to Fluorine (HONEYCOMB-433)Michal Cmarada96-433/+952
Change-Id: I142ebd2899272feff00abe7d4bae708f093ee3ec Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-09-24Add INFO.yaml fileVanessa Rene Valderrama1-0/+76
Add INFO.yaml to list: - Project description - Properties - Issue Tracking - Contacts - PTL information - Meeting information - Committer information Change-Id: Ibe3fae589600784d98880e017e54c66a34d0c2e3 Signed-off-by: Vanessa Rene Valderrama <vvalderrama@linuxfoundation.org>
2018-08-24Remove redundant ReadFailedException from Reader.isPresentMarek Gradzki4-6/+4
Change-Id: Ia64b0869d1f2d9620d233f31077e72d887ef4716 Signed-off-by: Marek Gradzki <margradz@gmail.com>
2018-08-23Make Validator.validateXXX methods optionalMarek Gradzki1-8/+16
Some of the writers do not support update, also write/delete might not require validation. Therefore, in order to reduce amount of boilerplate code, make validateXXX methods default with empty implementation. Change-Id: Id205b478900024c59834a6e6cb18bdbeb9b43792 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-21Mark improvements with TODO instead of FIXMEMarek Gradzki4-5/+4
Sonar reports FIXMES as issues with higher priority as TODOs. FIXMEs should only be used for known bugs, not for improvements. Also include JIRA issue ID in the TODO message. Change-Id: I47461d948421ff17532f17ecec3ddae84239511f Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-21RWUtils: move fields to comply with Java Code ConventionsMarek Gradzki1-11/+12
Change-Id: I2ab95afb733885b3034dfc6a8cbad795fbf5ba6c Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-17AbstractGenericWriter: remove xxxCurrent methodsMarek Gradzki2-61/+25
Use xxxCurrentAttributes instead to simplify call graph. Change-Id: I8201b115354dddd35ca0b63b2c72dfb4eac93646 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-17HONEYCOMB-431: add validation support to WritersMarek Gradzki12-32/+404
This patch introduces FlatWriterRegistry.validateModifications. Implementation iterates over writersOrder following bulkUpdate logic to properly support subtree writers case. Writers are now cabable of validating modifications. Commonly used implementations (GenericWriter and GenericListWriter) delegate validation capbility to Validators. Change-Id: If7a0bb0838c0b8f2c0393c989f3b03853a2ea679 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-17HONEYCOMB-431: delegate DataModification.validate to WriterRegistryMarek Gradzki8-36/+206
This patch introduces ModifiableDataTreeDelegator.validateCandidate that translates DataTreeCandidate to DataObjectUpdates and delegates validation to WriterRegistry (similarly as for bulk update). ModifiableDataTreeManager.commit implementation invokes validation before bulk update. To make it efficient, DataObjectUpdates are computed once and stored in DataTreeContext. Change-Id: If4bd558e64ed84c11c9c50c7a98a2aaa8db841bb Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-17HONEYCOMB-431: make DataModification.validate idempotentMarek Gradzki5-32/+125
This patch modifies contract of DataModification.validate to make it idempotent. ModifiableDataTreeManager.validate now invokes dataTree.validate on a copy of DataTreeModification. ModifiableDataTreeManager.validateCandidate was introduced to allow additional validation. Change-Id: I86fc101faff9b04afde2f3eb16fff4d4df2867ad Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-13Hide ResourceLoader.ResourceLoaderIml's constructorMarek Gradzki1-0/+4
Fixes issue reported by Sonar. Change-Id: Ibf9bc89ee09f151a56766213714829abdb7012bb Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-13Hide TranslationUtil's constructorMarek Gradzki1-1/+3
Utility classes should not be instantiated. Change-Id: Iff821556ad6b593bce6b3e056241dc7e2bbe0c8b Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-13Bump maven-sonar-plugin version to 3.4.1.1170Marek Gradzki1-2/+2
Change-Id: Ic490d8b850fcd270ff49e1c682f40c0324afe3d6 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-10remove obsolete HoneycombDOMBrokerProviderMichal Cmarada3-191/+0
this was used a while ago when we were using ODL dependencies with config subsystem. Once ODL moved to Blueprint this become obsolete. Several classes used in this provider are marked deprecated and are removed in ODL Fluorine. Change-Id: I5bd415a271a9d53ad40f785bdc3840c410f79249 Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-08-10HONEYCOMB-440: bump ODL dependencies to Oxygen-SR3Marek Gradzki2-8/+8
Change-Id: Ib178651a07b55f7e732a45751c31b678296b2083 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-09Rename TestValidate to EditConfigTestMarek Gradzki3-7/+7
The test does not use <validate> RPC in contrast to ValidateTest from: https://gerrit.fd.io/r/#/c/14040/ Change-Id: I57da44256515cf10afbd86ef7d7b1607caa3f52e Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-06javadoc: add missing <name> in pom filesMarek Gradzki2-0/+2
Change-Id: I2bed263c71b38e28706cb869232482b951158fd1 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-06HoneycombDOMRpcService: remove unnecessary cast to FunctionMarek Gradzki1-3/+1
Fixes issue reported by Sonar. Change-Id: I083eb089f1ccd691a2015eaa401fe5acf7c59d49 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-06RWUtils: use lambdas instead of anonymous inner classesMarek Gradzki1-26/+5
Change-Id: Ie17b819efd381983754065a821771eb3aac11d06 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-03Do not use FQN of DataBroker in ModifiableDataTreeDelegatorMarek Gradzki1-2/+3
Change-Id: I5944e9fd9388fbc533bf909b171b0672d798ad82 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-31Remove code repetitions from GenericListWriterMarek Gradzki1-14/+8
Change-Id: I4efbdcc4bc12e29bd767c7b8fa6696de62ac1d37 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-20Relese notes: update jira project version for 1.18.10Marek Gradzki2-3/+3
Change-Id: I02b4f5948ae8818412d1ae0f7b3e1ac4acd55726 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-20Bump honeycomb version to 1.18.10-SNAPSHOTMarek Gradzki75-147/+147
Change-Id: Ibd371b845debac895fad97b4e15732d858e00a3c Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27Register sutdown handler for Restconf server before startMarek Gradzki1-1/+1
Change-Id: I25a22a194048637ea72dd35767e1e1701b5723e4 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27DelegatingRewriteDeleteProducer: remove useles instanceof checkMarek Gradzki1-1/+0
DataContainerNode is DataContainerChild. Change-Id: I9122f9f3c27951f2d498f714d2ea15ebc96abdf3 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27bgp: mark parameters of RouteWriter @NonNullMarek Gradzki2-11/+9
The RouteWriter interface is used by LocRibChangeListener, which never passes null parameters. Change-Id: I33a775de6c67d24bc271c0af21c9634c661e85e9 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-21Cleanup WriterCustomizerMarek Gradzki1-5/+2
Change-Id: Ied63ccd3fbc7e645ba3fa2db16528b3209319fa7 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-13HONEYCOMB-439: bump ODL dependencies to Oxygen-SR2Marek Gradzki2-9/+9
Change-Id: I76cc110ac7e0a64cdad79a7614f9e8b5eb624428 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-11ModifiableDataTreeManager: remove redundant non-default constructorMarek Gradzki1-5/+1
Change-Id: I17dba7ad77f4d7865f887056062d0748ca699d44 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-11WriteTransaction: make sure TransactionCommitFailedException is thrownMarek Gradzki7-3/+298
DataTreeModification.ready() used by DataModification.validate() might throw IllegalArgumentException in case of missing mandatory nodes. Use broader Exception type in WriteTransaction.submit() to make sure contract defined by AsyncWriteTransaction is preserved. Change-Id: I95cb3e1e8c6db36df90d2c78e7d63c854189e2fd Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-07Bump odl.yang-binding version from 0.12.0 to 0.12.1Marek Gradzki1-1/+1
Change-Id: I37c247279c37c3fb066186c8390e827a9611b99e Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-07HONEYCOMB-432: bump ODL dependencies to Oxygen-SR1Marek Gradzki1-8/+8
Change-Id: Ibf01bcaf65bb048fcfae57b5ba0597faff5e4fe6 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-18Invoke CapabilityChangeNotificationProducer.close on shutdownMarek Gradzki1-2/+5
Also fixes Sonar warning regarding useless CapabilityChangeNotificationProducer instantiation. Change-Id: I376b834618d34f13615051abf622e6b12e031050 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-16HONEYCOMB-437: implement ReflexiveListReaderCustomizer.readCurrentAttributesMarek Gradzki2-41/+90
ReflexiveListReaderCustomizer used default NOOP implementation, which caused issues during serialization, because BindingNormalizedNodeCodecRegistry.toNormalizedNode requrires key to be set. Change-Id: I7822e07efe57cbdee2c539583776f8cc677ddab7 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-02javadoc: add missing <name> in pom filesMarek Gradzki24-1/+24
Change-Id: I3d65b568c3651e4b2474c25bdf80cf3fff416360 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-02bgp-extensions: fix ODL BGP links in javadocMarek Gradzki7-7/+6
Change-Id: I84b338774c8175a7e59f03db3b81297607df0141 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-25Collect all the updates for subtree writersMaros Marsalek3-7/+84
So far, when a subtree writer was registered on a list node and ModificationDiff detected 2 or more updated list items for that writer, FlatWriterRegistry just picked the first item in list, processed that one and ignored the rest. Change-Id: If66db1eaad5a3b5c35e5586f46fd83a0698e1728 Signed-off-by: Maros Marsalek <maros.mars@gmail.com>
2018-04-16WriteTransaction: log exception with error level when submit failsMarek Gradzki1-1/+1
Change-Id: Ibc269946c08702805531a62c40be295fecc6b4ce Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-10Fix various Sonar warningsMarek Gradzki6-17/+14
Change-Id: I0883042a80525b72f33e66fdb0d5b9e600dcc713 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-09release notes: set ODL project branch to stable-oxygenMarek Gradzki1-1/+1
Change-Id: I03b48e387d370a4e264fb8bf4e3b22a03656fbba Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-09Update jira project version in relese notes for 1.18.07Marek Gradzki2-3/+3
Change-Id: Ie86c53f0c5922704ea7cbb3e29ee258e53c2cc70 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-09Bump Honeycomb version to 1.18.07-SNAPSHOTMarek Gradzki75-147/+147
Change-Id: Ib0b9a2a2369730cd8a21e35e4dce0b62e45e8ad3 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>