Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I22b9589cbacb3b4d4f38f145362537f0c1dbd5db
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: Ie0940b9b761e747b07901c8ebe62a4be3840dee2
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: Icd61765bdcbc96feaf71f899158923762bb9e0ce
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: I31ab13577c78a4ff5f96256cf5d46e333ee3be86
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>
|
|
Change-Id: Ia64b0869d1f2d9620d233f31077e72d887ef4716
Signed-off-by: Marek Gradzki <margradz@gmail.com>
|
|
Some of the writers do not support update,
also write/delete might not require validation.
Therefore, in order to reduce amount of boilerplate code,
make validateXXX methods default with empty implementation.
Change-Id: Id205b478900024c59834a6e6cb18bdbeb9b43792
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
This patch introduces FlatWriterRegistry.validateModifications.
Implementation iterates over writersOrder following bulkUpdate logic
to properly support subtree writers case.
Writers are now cabable of validating modifications.
Commonly used implementations (GenericWriter and GenericListWriter)
delegate validation capbility to Validators.
Change-Id: If7a0bb0838c0b8f2c0393c989f3b03853a2ea679
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
This patch introduces ModifiableDataTreeDelegator.validateCandidate
that translates DataTreeCandidate to DataObjectUpdates
and delegates validation to WriterRegistry (similarly as for bulk update).
ModifiableDataTreeManager.commit implementation
invokes validation before bulk update.
To make it efficient, DataObjectUpdates are computed once
and stored in DataTreeContext.
Change-Id: If4bd558e64ed84c11c9c50c7a98a2aaa8db841bb
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
This patch modifies contract of DataModification.validate
to make it idempotent.
ModifiableDataTreeManager.validate now invokes dataTree.validate
on a copy of DataTreeModification.
ModifiableDataTreeManager.validateCandidate was introduced
to allow additional validation.
Change-Id: I86fc101faff9b04afde2f3eb16fff4d4df2867ad
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: Ibd371b845debac895fad97b4e15732d858e00a3c
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: Ib0b9a2a2369730cd8a21e35e4dce0b62e45e8ad3
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: Idb0fec8ab45ec76431ab6d05d70a61eee1929628
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I2b886a118ff5167df89a2922802b343ce5978c95
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Exceptions are Serializable.
Fields of Serializable class must be either Serializable or transient.
But DataObjects are not serializable, and there is really no reason to
serialize UpdateFailedException.
This patch excludes fields of the UpdateFailedException
from serialization process to fix Sonar warnings.
Change-Id: I1eb9408289241bb4fe6f712ed9208f8460eef317
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Serializable classes should have serialVersionUID defined.
Change-Id: I0ad79f6d82ed72bcea521c4cafc53219ff82a7fa
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Adds option to specify subtree writer that can handle whole subtree
of nodes without having whole subtree specified. Its checking
if node is children at runtime, rather than having pre-computed tree
Change-Id: Ic46f2bd6de84f0dd14865825399f5a90a1f80859
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
|
|
If indirect update(delete+create) fails in a way, that delete passed,
but update part failed, delete part must be reverted
Moves reverter creation to MDTG and test cases related too it to
ModifiableDataTreeDelegatorRevertTest
Fixes tracking of allready processed changes by tracking them
from perspective of processModifications() method
Introduces UpdateFailedException as replacement
for BulkUpdateException(now thrown also for single updates)
Separates ReverterImpl from FlatWriterRegistry and ads unit tests
Change-Id: If0066d0716d9476be89b1d99985b6745becac15e
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
|
|
Change-Id: I64bcd7e45da5d7431ba436ff6ad1ac62cd1d1051
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
If customizer does not support update directly,
updates for its handled nodes are broken up to delete + create pairs.
Change-Id: I2929109e8c9a1db0bef108367cf7d839135ce173
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
|
|
Change-Id: I63fa239e34178ab03c4eecd421bf19d80303d30e
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I6294fc266b704568d4e093a50d615f96eac153be
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: Ie7b486c266ea34df999e7122b5ef12d26aded863
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: Ia02ed73daaeea547d49c9ec2d4d7d10f4db85b5e
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
|
|
Due to incorrect instance of check, InitSubtreeReader was never created
in CompositeReaderRegistryBuilder.getSubtreeHandler().
As a consequence, initializers registered by subtreeAdd*, were not invoked.
The patch:
- fixes mentioned check,
- makes readers implement InitReader instead of directly
implementing Initializer
- includes missing unit tests for GenericReaders.
Change-Id: I93be59fafddb60dce00191958b5c8c62e7c2d289
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I99bc2593d50e59a6d4293e2d98ef3a9569a55008
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I47f37a60f276928672fc2bd53e948641d9278014
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I6b24a1d061c94d57730b20cde4c5b3c39444b119
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
So that they can influence whether empty data is to be considered as present
+ Move registries implementations from util to impl
+ Introduce DelegatingReader trait
+ Extend GenericReader where possible to reduce duplication
Change-Id: I5a416acd0c4eab1fbc30fcbe585719991dbe9215
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
Change-Id: Ib23453d4040d59a512686315995a5cf9e532cefc
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
Mapping allready processes changes for reverting by InstanceIdentifier
instead of using KeyedInstanceIdentifier(to prevent failing to identify
handleable nodes)
Modified logging to prevent double/triple logging of detailed cause
of failed bulk update
Reusing WriteContext for revert(removed try with resource to prevent
closing of write context before revert)
Change-Id: Ie939ebe443629f9cdad5b5b449aa8c5dac40ea67
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
To produce site for Honeycomb +
javadoc
asciidoc
To build the site:
mvn clean install site:attach-descriptor site
mvn site:stage -DstagingDirectory=/home/mmarsale/tmp/stage
Change-Id: I4246bb09ba02b74a2a9c84ee73f8dba02384fffa
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
problematic mockito-all changed to mockito-core( https://github.com/mockito/mockito/issues/324)
Translate Utils Splitted to multiple Trait Interfaces
Ipv4Translator - Logic for translation of ipv4-based data
Ipv6Translator - Logic for translation of ipv6-based data
MacTranslator - Logic for translation of mac-based data
AddressTranslator - Aggregation trait for Ipv4/Ipv6/Mac
JvppReplyConsumer - Logic for extracting replies from jvpp calls
ByteDataTranslator - any byte-based conversions
Plus some existing utility classes changed to traits
Change-Id: I342b625954223966802e65dca0fabf8456c89345
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
|
|
Change-Id: I6f055ae926aaf876863adb7eddadde0abefdda91
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
- Fix minor ones
- Report bigger and include issue number in comment
- Pull common dependencies into dependency management of common/parents
Change-Id: I06a6ac37c52b603fd73ed42023d6b2e7fa18010f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
of implemented interfaces.
Reader factories do not need to be AutoClosable.
Change-Id: I779e87eb0b03750e264df52e14eee58467ca799a
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
of implemented interfaces.
WriterFactories do not need to be AutoClosable.
Change-Id: I1947489b7eac2ccf4c34b3212c93ed76922a595f
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
|
|
Change-Id: I4c27d0ad2fd1655db2237ae914361f029093084c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
Change-Id: I27b09dc1fdf7597c8b0751d8cbf950500e03fa23
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
Modified to be thread save and generic
to be usable in all plugins
Change-Id: I26c90e8c8aa13c07fa389d86a9784e92e9532bcd
Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
|
|
Change-Id: I48aafb726de53b6ad3fb9b97c202f712dfa4a540
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
Change-Id: Ic5b90e397e3743623d01b206bc60bc5c7df6b981
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|
|
Creating folders:
- common/
- infra/
- v3po/
- vpp-common/
Change-Id: I2c39e1b17e39e7c0f0628f44aa5fe08563fa06e4
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
|