summaryrefslogtreecommitdiffstats
path: root/infra/translate-impl/src
AgeCommit message (Collapse)AuthorFilesLines
2018-08-17HONEYCOMB-431: add validation support to WritersMarek Gradzki7-26/+196
This patch introduces FlatWriterRegistry.validateModifications. Implementation iterates over writersOrder following bulkUpdate logic to properly support subtree writers case. Writers are now cabable of validating modifications. Commonly used implementations (GenericWriter and GenericListWriter) delegate validation capbility to Validators. Change-Id: If7a0bb0838c0b8f2c0393c989f3b03853a2ea679 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-31Remove code repetitions from GenericListWriterMarek Gradzki1-14/+8
Change-Id: I4efbdcc4bc12e29bd767c7b8fa6696de62ac1d37 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-25Collect all the updates for subtree writersMaros Marsalek2-7/+76
So far, when a subtree writer was registered on a list node and ModificationDiff detected 2 or more updated list items for that writer, FlatWriterRegistry just picked the first item in list, processed that one and ignored the rest. Change-Id: If66db1eaad5a3b5c35e5586f46fd83a0698e1728 Signed-off-by: Maros Marsalek <maros.mars@gmail.com>
2018-04-10Fix various Sonar warningsMarek Gradzki1-1/+1
Change-Id: I0883042a80525b72f33e66fdb0d5b9e600dcc713 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Fix revision of hc-aug-test.yangMarek Gradzki1-11/+11
Change-Id: I1ca0e255c1467af31a39eb515c9cd4e7b4a4948a Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-08Use Comparator.comparingInt instead of lambdaMarek Gradzki1-11/+11
Change-Id: I42372554876c27e4c5d4f053f537d6d52ff449f8 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-04Check for missing readers when building CompositeReaderRegistryJakub Morvay1-3/+9
Change-Id: Ic5e16e7a53836600236701caa51599bc0b957955 Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
2017-12-20Improve read failed error messageMarek Gradzki1-1/+1
Change-Id: I5b74855284765b8281ec79122cad69d1a8f87856 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-22Fix Sonar warnings in FlatWriterRegistryMarek Gradzki1-10/+3
Remove useless variables and simplify if conditions. Change-Id: I48a28334c47103057832f640c692c25625483bb6 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-22Cleanup various Sonar waringsMarek Gradzki3-6/+0
Unused code, imports, etc. Change-Id: Icb19d6a877d5ddbfd85caa86c4e62880e4db3c44 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-22Add missing @Override annotationsMarek Gradzki1-0/+1
Fix isses reported by Sonar thanks to IntelliJ's code inspection. Change-Id: Ief7b4307d4b90e107f010d7feaa307776afaf947 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-03HONEYCOMB-359 - Wildcarded writersJan Srnicek6-54/+267
Adds option to specify subtree writer that can handle whole subtree of nodes without having whole subtree specified. Its checking if node is children at runtime, rather than having pre-computed tree Change-Id: Ic46f2bd6de84f0dd14865825399f5a90a1f80859 Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
2017-10-23HONEYCOMB-405 - Revert fix for indirect updatesJan Srnicek2-173/+91
If indirect update(delete+create) fails in a way, that delete passed, but update part failed, delete part must be reverted Moves reverter creation to MDTG and test cases related too it to ModifiableDataTreeDelegatorRevertTest Fixes tracking of allready processed changes by tracking them from perspective of processModifications() method Introduces UpdateFailedException as replacement for BulkUpdateException(now thrown also for single updates) Separates ReverterImpl from FlatWriterRegistry and ads unit tests Change-Id: If0066d0716d9476be89b1d99985b6745becac15e Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
2017-08-16HONEYCOMB-386 - Make update optionalJan Srnicek10-50/+190
If customizer does not support update directly, updates for its handled nodes are broken up to delete + create pairs. Change-Id: I2929109e8c9a1db0bef108367cf7d839135ce173 Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
2017-06-09Move ordering logic out of AbstractSubtreeManagerRegistryBuilderBuilderMarek Gradzki4-15/+24
Introduces YangDAG that maintains topological order for yang schema nodes and can be used by other components to read additional graph edges, e.g. from file (HONEYCOMB-365). Change-Id: Ia3046d38ffb4ca222412309f6c4391afc9315bd2 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-02-27HONEYCOMB-344 - structural reader for listJan Srnicek2-4/+19
Change-Id: Ia02ed73daaeea547d49c9ec2d4d7d10f4db85b5e Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
2017-02-07Prevent submitting of structural reader for list nodeJan Srnicek2-1/+16
Static customizer must be provided instead till HONEYCOMB-344 is resolved Change-Id: Id71f69fe23b156e6de10eed06a3596de8e602bbe Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
2017-01-10HONEYCOMB-331: unify initialization handlingMarek Gradzki11-156/+529
Due to incorrect instance of check, InitSubtreeReader was never created in CompositeReaderRegistryBuilder.getSubtreeHandler(). As a consequence, initializers registered by subtreeAdd*, were not invoked. The patch: - fixes mentioned check, - makes readers implement InitReader instead of directly implementing Initializer - includes missing unit tests for GenericReaders. Change-Id: I93be59fafddb60dce00191958b5c8c62e7c2d289 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2016-11-23HONEYCOMB-170 Add more information to RevertFailedExMaros Marsalek2-60/+64
Change-Id: I6b24a1d061c94d57730b20cde4c5b3c39444b119 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
2016-11-08HONEYCOMB-270 Add isPresent() to Readers/CustomizersMaros Marsalek20-28/+2512
So that they can influence whether empty data is to be considered as present + Move registries implementations from util to impl + Introduce DelegatingReader trait + Extend GenericReader where possible to reduce duplication Change-Id: I5a416acd0c4eab1fbc30fcbe585719991dbe9215 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
2016-10-28HONEYCOMB-274 Fix checkstyle license checksMaros Marsalek1-1/+1
Change-Id: I9a7783bf072b2e2396f0fa1a784bcb57adb689b4 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
2016-10-28Honeycomb-73 Extensible initializers frameworkMaros Marsalek4-8/+166
Change-Id: Ib23453d4040d59a512686315995a5cf9e532cefc Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
2016-09-16HONEYCOMB-194 Raise unit test coverage of transle-impl to 80%Maros Marsalek4-30/+281
Change-Id: I8d032e1a90004ee4bd6ebbae002a8e66a7e85919 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
2016-09-07Cleanup TODOs and FIXMEsMaros Marsalek4-10/+40
- Fix minor ones - Report bigger and include issue number in comment - Pull common dependencies into dependency management of common/parents Change-Id: I06a6ac37c52b603fd73ed42023d6b2e7fa18010f Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
2016-07-29HONEYCOMB-130: Rename infra packages(remove vpp/v3po)Maros Marsalek6-32/+32
Change-Id: Ic5b90e397e3743623d01b206bc60bc5c7df6b981 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
2016-07-29HONEYCOMB-130: Separate v3po plugin from HC infraMaros Marsalek6-0/+501
Creating folders: - common/ - infra/ - v3po/ - vpp-common/ Change-Id: I2c39e1b17e39e7c0f0628f44aa5fe08563fa06e4 Signed-off-by: Maros Marsalek <mmarsale@cisco.com>