summaryrefslogtreecommitdiffstats
path: root/infra
AgeCommit message (Collapse)AuthorFilesLines
2018-06-11ModifiableDataTreeManager: remove redundant non-default constructorMarek Gradzki1-5/+1
Change-Id: I17dba7ad77f4d7865f887056062d0748ca699d44 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-11WriteTransaction: make sure TransactionCommitFailedException is thrownMarek Gradzki7-3/+298
DataTreeModification.ready() used by DataModification.validate() might throw IllegalArgumentException in case of missing mandatory nodes. Use broader Exception type in WriteTransaction.submit() to make sure contract defined by AsyncWriteTransaction is preserved. Change-Id: I95cb3e1e8c6db36df90d2c78e7d63c854189e2fd Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-18Invoke CapabilityChangeNotificationProducer.close on shutdownMarek Gradzki1-2/+5
Also fixes Sonar warning regarding useless CapabilityChangeNotificationProducer instantiation. Change-Id: I376b834618d34f13615051abf622e6b12e031050 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-16HONEYCOMB-437: implement ReflexiveListReaderCustomizer.readCurrentAttributesMarek Gradzki2-41/+90
ReflexiveListReaderCustomizer used default NOOP implementation, which caused issues during serialization, because BindingNormalizedNodeCodecRegistry.toNormalizedNode requrires key to be set. Change-Id: I7822e07efe57cbdee2c539583776f8cc677ddab7 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-02javadoc: add missing <name> in pom filesMarek Gradzki23-1/+23
Change-Id: I3d65b568c3651e4b2474c25bdf80cf3fff416360 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-02bgp-extensions: fix ODL BGP links in javadocMarek Gradzki6-6/+6
Change-Id: I84b338774c8175a7e59f03db3b81297607df0141 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-25Collect all the updates for subtree writersMaros Marsalek3-7/+84
So far, when a subtree writer was registered on a list node and ModificationDiff detected 2 or more updated list items for that writer, FlatWriterRegistry just picked the first item in list, processed that one and ignored the rest. Change-Id: If66db1eaad5a3b5c35e5586f46fd83a0698e1728 Signed-off-by: Maros Marsalek <maros.mars@gmail.com>
2018-04-16WriteTransaction: log exception with error level when submit failsMarek Gradzki1-1/+1
Change-Id: Ibc269946c08702805531a62c40be295fecc6b4ce Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-10Fix various Sonar warningsMarek Gradzki6-17/+14
Change-Id: I0883042a80525b72f33e66fdb0d5b9e600dcc713 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-09Bump Honeycomb version to 1.18.07-SNAPSHOTMarek Gradzki49-94/+94
Change-Id: Ib0b9a2a2369730cd8a21e35e4dce0b62e45e8ad3 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-23HONEYCOMB-424: bump ODL dependencies to OxygenMarek Gradzki50-219/+243
Change-Id: I3160e5df4e66b3b3c732619fc1fc7599459fda76 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07Fix Netconf TCP server shutdownMarek Gradzki1-9/+17
Change-Id: I0c74799a7249777c3258be915e9a95836fe0265e Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07ShutdownHandlerImpl: remove registered components after shutdown is performedMarek Gradzki1-0/+5
Prevents invoking AutoCloseable.close(), which might not be idempotent. Change-Id: Id28200fb68a4c6e38878cf4f0b8aaee298dbc37b Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07Fix Restconf server shutdownMarek Gradzki2-15/+36
Change-Id: Ia7c0fc2d269ae88170297ef22476c8a61121238a Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07Move shutdown hook registration to dedicated providerMarek Gradzki4-7/+41
This change would allow using ShutdownHandlerImpl in integration tests. Change-Id: I854f65d03b9e1a495fda7211fd1b7fd51b4e5ba3 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07Fix handling of RPCs that do not produce a resultMarek Gradzki2-14/+26
The output statement of RPC operation is optional. In such cases DefaultDOMRpcResult should be initialized with null result. Change-Id: Ia832e480b3c72607b3636493bc044a9144f247be Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07Post HONEYCOMB-161 cleanupMarek Gradzki2-2/+0
Change-Id: I46652c9f109a6ede60cfb3143d945fe8b6f1f042 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-23HONEYCOMB-418: Bump ODL dependencies from Nitrogen SR1 to Nitrogen SR2Marek Gradzki1-1/+1
Change-Id: I98f73e0cce217202e8c335b1fa06f1b3fc8bce05 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Use XMLStreamNormalizedNodeStreamWriter from yang-data-codec-xmlMarek Gradzki2-1/+5
instead of old and deprecated version from yang-data-impl. Change-Id: If3f9dbffe83cdde29d2f4996dbd299a60bab90a9 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Use YangParserTestUtils instead of CrossSourceStatementReactor.BuildActionMarek Gradzki4-20/+22
Simplifies code and removes usages of deprecated YangStatementSourceImpl. Change-Id: I012e2de7a5a902927eaec87370f1850d54fbf4ee Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Remove usages of deprecated BindingNormalizedNodeSerializer from yantoolsMarek Gradzki8-8/+8
Use mdsal version: org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeSerializer instead of org.opendaylight.yangtools.binding.data.codec.api.BindingNormalizedNodeSerializer Change-Id: Idfb977acee95de40183d4574565c46ac9ab54a27 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Fix revision of hc-aug-test.yangMarek Gradzki4-39/+39
Change-Id: I1ca0e255c1467af31a39eb515c9cd4e7b4a4948a Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Improve error messages in distro testsMarek Gradzki2-5/+7
Change-Id: Ie0bc2e2add7940cb8f0ce2d5e4ea41d1e1c9d991 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-30HONEYCOMB-414: use NetconfNorthboundSshServer for NETCONF initializationMarek Gradzki2-103/+14
instead of rewriting it in HC. Change-Id: Id2b5cb1b7bcd38728721ce92a7b5dbe1d919731c Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-17Integration test for SubtreeWriter updateMarek Gradzki2-1/+52
Change-Id: Ic8d2cd524ea2d22859df28cb48aa41d5539efbee Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-16Improve integration tests for SubtreeWriterMarek Gradzki5-52/+227
Change-Id: I20209b800eaa892e0fb742066003e956d00bbb22 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-09Bump honeycomb version to 1.18.04-SNAPSHOTMarek Gradzki49-94/+94
Change-Id: Idb0fec8ab45ec76431ab6d05d70a61eee1929628 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-08Use Comparator.comparingInt instead of lambdaMarek Gradzki1-11/+11
Change-Id: I42372554876c27e4c5d4f053f537d6d52ff449f8 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-04Check for missing readers when building CompositeReaderRegistryJakub Morvay1-3/+9
Change-Id: Ic5e16e7a53836600236701caa51599bc0b957955 Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
2017-12-20Improve read failed error messageMarek Gradzki1-1/+1
Change-Id: I5b74855284765b8281ec79122cad69d1a8f87856 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-12-14Add Logger for RpcRegistryImplMarek Gradzki2-5/+9
Change-Id: I6ef0133f0128fbf5cfb9ed9f0e738af0bda3a852 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-12-11Do not hardcode websocket parameters in RestconfConfigurationMarek Gradzki1-2/+2
Change-Id: I3891eae1aac45fcd6e8adf4384c48d657998ed27 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-12-05Allow table type registration for BGP extensionjan.srnicek1-2/+2
modules with different package name Change-Id: I0f6336052081fff923711e71cf85b748d8d4c730 Signed-off-by: jan.srnicek <jan.srnicek@pantheon.tech>
2017-12-04Fixed bug in ModificationDiffMartin Sunal1-1/+3
when leaf is modified in augmentation modification type is subtree-modified. Implementation expected only type write or delete. Change-Id: I3146b1a7322bd73d7972fecaceeafa654eeb84a4 Signed-off-by: Martin Sunal <msunal@frinx.io> Signed-off-by: Maros Marsalek <maros.mars@gmail.com>
2017-11-30HONEYCOMB-417: bump ODL dependencies to Nitrogen SR1Marek Gradzki5-1/+10
Change-Id: I6fe0d310a36dd8b0262c7db53f520616e65022e4 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-24Fix getRevertTransactionContext() closeMarek Gradzki1-8/+17
Also suppress Sonar warnings casused by SONARJAVA-1670. until SonarCube is upgraded (HONEYCOMB-419). Change-Id: Id5b775dfdd97180f6627192bd04aaac4f1e4e4c0 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-23Fix method/modifiers ordering to comply with JLSMarek Gradzki6-79/+79
Change-Id: I2b886a118ff5167df89a2922802b343ce5978c95 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-22Fix Sonar warnings in FlatWriterRegistryMarek Gradzki1-10/+3
Remove useless variables and simplify if conditions. Change-Id: I48a28334c47103057832f640c692c25625483bb6 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-22Cleanup various Sonar waringsMarek Gradzki9-69/+10
Unused code, imports, etc. Change-Id: Icb19d6a877d5ddbfd85caa86c4e62880e4db3c44 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-22Make fields of UpdateFailedException transientMarek Gradzki1-2/+5
Exceptions are Serializable. Fields of Serializable class must be either Serializable or transient. But DataObjects are not serializable, and there is really no reason to serialize UpdateFailedException. This patch excludes fields of the UpdateFailedException from serialization process to fix Sonar warnings. Change-Id: I1eb9408289241bb4fe6f712ed9208f8460eef317 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-22Add missing @Override annotationsMarek Gradzki19-2/+36
Fix isses reported by Sonar thanks to IntelliJ's code inspection. Change-Id: Ief7b4307d4b90e107f010d7feaa307776afaf947 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-22Add serialVersionUID to UpdateFailedExceptionMarek Gradzki1-0/+1
Serializable classes should have serialVersionUID defined. Change-Id: I0ad79f6d82ed72bcea521c4cafc53219ff82a7fa Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-20Use InetAddresses.forString instead of InetAddress.getByNameMarek Gradzki4-25/+9
Unlike InetAddress.getByName(), Guava's InetAddresses.forString() never cause DNS services to be accessed. JDK equivalents whenever you are expecting to handle only IP address string literals, so there is no blocking DNS penalty for a malformed string. See: https://google.github.io/guava/releases/22.0/api/docs/com/google/common/net/InetAddresses.html#forString-java.lang.String- Change-Id: Id1fc5fa45465b0e0b3aea7d60b9fdb855240d902 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-10HONEYCOMB-385: bump ODL dependencies to NitrogenMarek Gradzki21-148/+130
* guava bumped to 22.0 (same as used by ODL) * use 4K RSA for SSH server (related to bouncy-castle bump in ODL) - based on https://git.opendaylight.org/gerrit/#/c/60138/2 - also fixes HC2VPP-207 * removed some yang models from netconf-whitelist.xml, that are no longer present in ODL dependencies, * increased timeouts in distro tests, because generating 4K RSA key my last longer (especially on slow jenkins nodes). * EmptyMountPointService exposed to enable reuse by notification and restconf providers Change-Id: I2ff32bd7f0298716210fcfee4918007a42fab171 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-07Make restconf depend on miminal-distribution-coreMarek Gradzki2-5/+6
Follows infra/notrthbound/netconf dependency direction. Change-Id: Ie29115e2b0b969d33270493c6d6cc4e9bda5e009 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2017-11-06HONEYCOMB-359 - Wildcarded writers for BGP extensionsJan Srnicek10-47/+189
Defines wildcarded writers for BGP extensions to be able to write theirs respective part of ApplicationRib Change-Id: I0057b59c5977d5f75e0bc3c0c8eae9b8cfdf0f85 Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
2017-11-03HONEYCOMB-359 - Wildcarded writersJan Srnicek16-120/+419
Adds option to specify subtree writer that can handle whole subtree of nodes without having whole subtree specified. Its checking if node is children at runtime, rather than having pre-computed tree Change-Id: Ic46f2bd6de84f0dd14865825399f5a90a1f80859 Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
2017-10-23HONEYCOMB-405 - Revert fix for indirect updatesJan Srnicek12-595/+950
If indirect update(delete+create) fails in a way, that delete passed, but update part failed, delete part must be reverted Moves reverter creation to MDTG and test cases related too it to ModifiableDataTreeDelegatorRevertTest Fixes tracking of allready processed changes by tracking them from perspective of processModifications() method Introduces UpdateFailedException as replacement for BulkUpdateException(now thrown also for single updates) Separates ReverterImpl from FlatWriterRegistry and ads unit tests Change-Id: If0066d0716d9476be89b1d99985b6745becac15e Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
2017-10-20Adjust benchmark paramsJan Srnicek2-26/+115
Increases number of iterations and reduces iteration time, to produce more representative results. Also describes what each annotation/parameter is used for Change-Id: I0d8b693620c01a617870cc1999bfefbd2e0377fd Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>
2017-10-09HONEYCOMB-363 - Bgp extension modulesJan Srnicek38-228/+1485
Provides maven modules per bgp extension. Defines common configuration that can be used to define new extensions(AbstractBgpExtensionModule). Change-Id: I1c8ff65b6f9aa5474026f4bdf42476bd0559208e Signed-off-by: Jan Srnicek <jsrnicek@cisco.com>