summaryrefslogtreecommitdiffstats
path: root/infra
AgeCommit message (Collapse)AuthorFilesLines
2018-09-25Bump ODL dependencies to Fluorine (HONEYCOMB-433)Michal Cmarada92-424/+927
Change-Id: I142ebd2899272feff00abe7d4bae708f093ee3ec Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-08-24Remove redundant ReadFailedException from Reader.isPresentMarek Gradzki4-6/+4
Change-Id: Ia64b0869d1f2d9620d233f31077e72d887ef4716 Signed-off-by: Marek Gradzki <margradz@gmail.com>
2018-08-23Make Validator.validateXXX methods optionalMarek Gradzki1-8/+16
Some of the writers do not support update, also write/delete might not require validation. Therefore, in order to reduce amount of boilerplate code, make validateXXX methods default with empty implementation. Change-Id: Id205b478900024c59834a6e6cb18bdbeb9b43792 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-21Mark improvements with TODO instead of FIXMEMarek Gradzki4-5/+4
Sonar reports FIXMES as issues with higher priority as TODOs. FIXMEs should only be used for known bugs, not for improvements. Also include JIRA issue ID in the TODO message. Change-Id: I47461d948421ff17532f17ecec3ddae84239511f Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-21RWUtils: move fields to comply with Java Code ConventionsMarek Gradzki1-11/+12
Change-Id: I2ab95afb733885b3034dfc6a8cbad795fbf5ba6c Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-17AbstractGenericWriter: remove xxxCurrent methodsMarek Gradzki2-61/+25
Use xxxCurrentAttributes instead to simplify call graph. Change-Id: I8201b115354dddd35ca0b63b2c72dfb4eac93646 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-17HONEYCOMB-431: add validation support to WritersMarek Gradzki12-32/+404
This patch introduces FlatWriterRegistry.validateModifications. Implementation iterates over writersOrder following bulkUpdate logic to properly support subtree writers case. Writers are now cabable of validating modifications. Commonly used implementations (GenericWriter and GenericListWriter) delegate validation capbility to Validators. Change-Id: If7a0bb0838c0b8f2c0393c989f3b03853a2ea679 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-17HONEYCOMB-431: delegate DataModification.validate to WriterRegistryMarek Gradzki8-36/+206
This patch introduces ModifiableDataTreeDelegator.validateCandidate that translates DataTreeCandidate to DataObjectUpdates and delegates validation to WriterRegistry (similarly as for bulk update). ModifiableDataTreeManager.commit implementation invokes validation before bulk update. To make it efficient, DataObjectUpdates are computed once and stored in DataTreeContext. Change-Id: If4bd558e64ed84c11c9c50c7a98a2aaa8db841bb Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-17HONEYCOMB-431: make DataModification.validate idempotentMarek Gradzki5-32/+125
This patch modifies contract of DataModification.validate to make it idempotent. ModifiableDataTreeManager.validate now invokes dataTree.validate on a copy of DataTreeModification. ModifiableDataTreeManager.validateCandidate was introduced to allow additional validation. Change-Id: I86fc101faff9b04afde2f3eb16fff4d4df2867ad Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-13Hide ResourceLoader.ResourceLoaderIml's constructorMarek Gradzki1-0/+4
Fixes issue reported by Sonar. Change-Id: Ibf9bc89ee09f151a56766213714829abdb7012bb Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-13Hide TranslationUtil's constructorMarek Gradzki1-1/+3
Utility classes should not be instantiated. Change-Id: Iff821556ad6b593bce6b3e056241dc7e2bbe0c8b Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-10remove obsolete HoneycombDOMBrokerProviderMichal Cmarada3-191/+0
this was used a while ago when we were using ODL dependencies with config subsystem. Once ODL moved to Blueprint this become obsolete. Several classes used in this provider are marked deprecated and are removed in ODL Fluorine. Change-Id: I5bd415a271a9d53ad40f785bdc3840c410f79249 Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.tech>
2018-08-09Rename TestValidate to EditConfigTestMarek Gradzki3-7/+7
The test does not use <validate> RPC in contrast to ValidateTest from: https://gerrit.fd.io/r/#/c/14040/ Change-Id: I57da44256515cf10afbd86ef7d7b1607caa3f52e Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-06javadoc: add missing <name> in pom filesMarek Gradzki2-0/+2
Change-Id: I2bed263c71b38e28706cb869232482b951158fd1 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-06HoneycombDOMRpcService: remove unnecessary cast to FunctionMarek Gradzki1-3/+1
Fixes issue reported by Sonar. Change-Id: I083eb089f1ccd691a2015eaa401fe5acf7c59d49 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-06RWUtils: use lambdas instead of anonymous inner classesMarek Gradzki1-26/+5
Change-Id: Ie17b819efd381983754065a821771eb3aac11d06 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-08-03Do not use FQN of DataBroker in ModifiableDataTreeDelegatorMarek Gradzki1-2/+3
Change-Id: I5944e9fd9388fbc533bf909b171b0672d798ad82 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-31Remove code repetitions from GenericListWriterMarek Gradzki1-14/+8
Change-Id: I4efbdcc4bc12e29bd767c7b8fa6696de62ac1d37 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-07-20Bump honeycomb version to 1.18.10-SNAPSHOTMarek Gradzki49-94/+94
Change-Id: Ibd371b845debac895fad97b4e15732d858e00a3c Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27Register sutdown handler for Restconf server before startMarek Gradzki1-1/+1
Change-Id: I25a22a194048637ea72dd35767e1e1701b5723e4 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27DelegatingRewriteDeleteProducer: remove useles instanceof checkMarek Gradzki1-1/+0
DataContainerNode is DataContainerChild. Change-Id: I9122f9f3c27951f2d498f714d2ea15ebc96abdf3 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-27bgp: mark parameters of RouteWriter @NonNullMarek Gradzki2-11/+9
The RouteWriter interface is used by LocRibChangeListener, which never passes null parameters. Change-Id: I33a775de6c67d24bc271c0af21c9634c661e85e9 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-21Cleanup WriterCustomizerMarek Gradzki1-5/+2
Change-Id: Ied63ccd3fbc7e645ba3fa2db16528b3209319fa7 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-11ModifiableDataTreeManager: remove redundant non-default constructorMarek Gradzki1-5/+1
Change-Id: I17dba7ad77f4d7865f887056062d0748ca699d44 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-06-11WriteTransaction: make sure TransactionCommitFailedException is thrownMarek Gradzki7-3/+298
DataTreeModification.ready() used by DataModification.validate() might throw IllegalArgumentException in case of missing mandatory nodes. Use broader Exception type in WriteTransaction.submit() to make sure contract defined by AsyncWriteTransaction is preserved. Change-Id: I95cb3e1e8c6db36df90d2c78e7d63c854189e2fd Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-18Invoke CapabilityChangeNotificationProducer.close on shutdownMarek Gradzki1-2/+5
Also fixes Sonar warning regarding useless CapabilityChangeNotificationProducer instantiation. Change-Id: I376b834618d34f13615051abf622e6b12e031050 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-16HONEYCOMB-437: implement ReflexiveListReaderCustomizer.readCurrentAttributesMarek Gradzki2-41/+90
ReflexiveListReaderCustomizer used default NOOP implementation, which caused issues during serialization, because BindingNormalizedNodeCodecRegistry.toNormalizedNode requrires key to be set. Change-Id: I7822e07efe57cbdee2c539583776f8cc677ddab7 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-02javadoc: add missing <name> in pom filesMarek Gradzki23-1/+23
Change-Id: I3d65b568c3651e4b2474c25bdf80cf3fff416360 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-05-02bgp-extensions: fix ODL BGP links in javadocMarek Gradzki6-6/+6
Change-Id: I84b338774c8175a7e59f03db3b81297607df0141 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-25Collect all the updates for subtree writersMaros Marsalek3-7/+84
So far, when a subtree writer was registered on a list node and ModificationDiff detected 2 or more updated list items for that writer, FlatWriterRegistry just picked the first item in list, processed that one and ignored the rest. Change-Id: If66db1eaad5a3b5c35e5586f46fd83a0698e1728 Signed-off-by: Maros Marsalek <maros.mars@gmail.com>
2018-04-16WriteTransaction: log exception with error level when submit failsMarek Gradzki1-1/+1
Change-Id: Ibc269946c08702805531a62c40be295fecc6b4ce Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-10Fix various Sonar warningsMarek Gradzki6-17/+14
Change-Id: I0883042a80525b72f33e66fdb0d5b9e600dcc713 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-04-09Bump Honeycomb version to 1.18.07-SNAPSHOTMarek Gradzki49-94/+94
Change-Id: Ib0b9a2a2369730cd8a21e35e4dce0b62e45e8ad3 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-23HONEYCOMB-424: bump ODL dependencies to OxygenMarek Gradzki50-219/+243
Change-Id: I3160e5df4e66b3b3c732619fc1fc7599459fda76 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07Fix Netconf TCP server shutdownMarek Gradzki1-9/+17
Change-Id: I0c74799a7249777c3258be915e9a95836fe0265e Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07ShutdownHandlerImpl: remove registered components after shutdown is performedMarek Gradzki1-0/+5
Prevents invoking AutoCloseable.close(), which might not be idempotent. Change-Id: Id28200fb68a4c6e38878cf4f0b8aaee298dbc37b Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07Fix Restconf server shutdownMarek Gradzki2-15/+36
Change-Id: Ia7c0fc2d269ae88170297ef22476c8a61121238a Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07Move shutdown hook registration to dedicated providerMarek Gradzki4-7/+41
This change would allow using ShutdownHandlerImpl in integration tests. Change-Id: I854f65d03b9e1a495fda7211fd1b7fd51b4e5ba3 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07Fix handling of RPCs that do not produce a resultMarek Gradzki2-14/+26
The output statement of RPC operation is optional. In such cases DefaultDOMRpcResult should be initialized with null result. Change-Id: Ia832e480b3c72607b3636493bc044a9144f247be Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-03-07Post HONEYCOMB-161 cleanupMarek Gradzki2-2/+0
Change-Id: I46652c9f109a6ede60cfb3143d945fe8b6f1f042 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-23HONEYCOMB-418: Bump ODL dependencies from Nitrogen SR1 to Nitrogen SR2Marek Gradzki1-1/+1
Change-Id: I98f73e0cce217202e8c335b1fa06f1b3fc8bce05 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Use XMLStreamNormalizedNodeStreamWriter from yang-data-codec-xmlMarek Gradzki2-1/+5
instead of old and deprecated version from yang-data-impl. Change-Id: If3f9dbffe83cdde29d2f4996dbd299a60bab90a9 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Use YangParserTestUtils instead of CrossSourceStatementReactor.BuildActionMarek Gradzki4-20/+22
Simplifies code and removes usages of deprecated YangStatementSourceImpl. Change-Id: I012e2de7a5a902927eaec87370f1850d54fbf4ee Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Remove usages of deprecated BindingNormalizedNodeSerializer from yantoolsMarek Gradzki8-8/+8
Use mdsal version: org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeSerializer instead of org.opendaylight.yangtools.binding.data.codec.api.BindingNormalizedNodeSerializer Change-Id: Idfb977acee95de40183d4574565c46ac9ab54a27 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Fix revision of hc-aug-test.yangMarek Gradzki4-39/+39
Change-Id: I1ca0e255c1467af31a39eb515c9cd4e7b4a4948a Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-02-02Improve error messages in distro testsMarek Gradzki2-5/+7
Change-Id: Ie0bc2e2add7940cb8f0ce2d5e4ea41d1e1c9d991 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-30HONEYCOMB-414: use NetconfNorthboundSshServer for NETCONF initializationMarek Gradzki2-103/+14
instead of rewriting it in HC. Change-Id: Id2b5cb1b7bcd38728721ce92a7b5dbe1d919731c Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-17Integration test for SubtreeWriter updateMarek Gradzki2-1/+52
Change-Id: Ic8d2cd524ea2d22859df28cb48aa41d5539efbee Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-16Improve integration tests for SubtreeWriterMarek Gradzki5-52/+227
Change-Id: I20209b800eaa892e0fb742066003e956d00bbb22 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
2018-01-09Bump honeycomb version to 1.18.04-SNAPSHOTMarek Gradzki49-94/+94
Change-Id: Idb0fec8ab45ec76431ab6d05d70a61eee1929628 Signed-off-by: Marek Gradzki <mgradzki@cisco.com>